From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH 4/4] drm/panel: s6e8aa0: Use static inline for upcasting Date: Tue, 22 Jul 2014 09:33:21 +0200 Message-ID: <53CE13C1.3050301@samsung.com> References: <1406013141-18552-1-git-send-email-thierry.reding@gmail.com> <1406013141-18552-4-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by gabe.freedesktop.org (Postfix) with ESMTP id 000546E246 for ; Tue, 22 Jul 2014 00:33:48 -0700 (PDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N9300IDHRO24S20@mailout4.w1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 22 Jul 2014 08:33:38 +0100 (BST) In-reply-to: <1406013141-18552-4-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 07/22/2014 09:12 AM, Thierry Reding wrote: > From: Thierry Reding > > Use a static inline function for upcasting a struct drm_panel to the > driver-specific structure. The advantage over using a macro is that it > gives us additional type checking. > > Signed-off-by: Thierry Reding Acked-by: Andrzej Hajda > --- > drivers/gpu/drm/panel/panel-s6e8aa0.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-s6e8aa0.c b/drivers/gpu/drm/panel/panel-s6e8aa0.c > index d39bee36816c..6034d300d218 100644 > --- a/drivers/gpu/drm/panel/panel-s6e8aa0.c > +++ b/drivers/gpu/drm/panel/panel-s6e8aa0.c > @@ -120,7 +120,10 @@ struct s6e8aa0 { > int error; > }; > > -#define panel_to_s6e8aa0(p) container_of(p, struct s6e8aa0, panel) > +static inline struct s6e8aa0 *panel_to_s6e8aa0(struct drm_panel *panel) > +{ > + return container_of(panel, struct s6e8aa0, panel); > +} > > static int s6e8aa0_clear_error(struct s6e8aa0 *ctx) > {