Re: [RFC] perf to ctf converter

[Sebastian Andrzej Siewior <bigeasy@linutronix.de>]

On 07/22/2014 01:25 PM, Jiri Olsa wrote:

> I've got it running... make LIBBABELTRACE_DIR=/opt/libbabeltrace/ ugh ;-)
> 
> [jolsa@krava perf]$ LD_LIBRARY_PATH=/opt/libbabeltrace/lib /opt/libbabeltrace/bin/babeltrace ./ctf-data/
> 
> [04:41:11.445378840] (+?.?????????) sched:sched_switch: { }, { pid = 5782, comm = "ls", prev_comm = [ [0] = "ls", [1] = "s", [2] = "", [3] = "f", [4] = "", [5] = "", [6] = "-x86_64-l", [7] = "x86_64-l", [8] = "86_64-l", [9] = "6_64-l", [10] = "_64-l", [11] = "64-l", [12] = "4-l", [13] = "-l", [14] = "l", [15] = "" ], prev_pid = 5782, prev_prio = 120, prev_state = 0x1, next_comm = [ [0] = "kworker/0:0", [1] = "worker/0:0", [2] = "orker/0:0", [3] = "rker/0:0", [4] = "ker/0:0", [5] = "er/0:0", [6] = "r/0:0", [7] = "/0:0", [8] = "0:0", [9] = ":0", [10] = "0", [11] = "", [12] = "", [13] = "", [14] = "", [15] = "" ], next_pid = 2376, next_prio = 120 }
> [04:41:11.445390175] (+0.000011335) sched:sched_switch: { }, { pid = 5782, comm = "ls", prev_comm = [ [0] = "ls", [1] = "s", [2] = "", [3] = "f", [4] = "", [5] = "", [6] = "-x86_64-l", [7] = "x86_64-l", [8] = "86_64-l", [9] = "6_64-l", [10] = "_64-l", [11] = "64-l", [12] = "4-l", [13] = "-l", [14] = "l", [15] = "" ], prev_pid = 5782, prev_prio = 120, prev_state = 0x1, next_comm = [ [0] = "kworker/0:0", [1] = "worker/0:0", [2] = "orker/0:0", [3] = "rker/0:0", [4] = "ker/0:0", [5] = "er/0:0", [6] = "r/0:0", [7] = "/0:0", [8] = "0:0", [9] = ":0", [10] = "0", [11] = "", [12] = "", [13] = "", [14] = "", [15] = "" ], next_pid = 2376, next_prio = 120 }
> 
> ...
> 
> looks like we need some better string arg handling,
> but we'll get there soon or later

I'm looking at how python gets it nicer…

> we'd like to have single/compact change commits.. so far I think 
> we can go with following commits:
> 
>   perf tools: VF=2 code
>   perf tools: Feature check for libbabeltrace
>   perf tools: Add new data command
> 
> and merge your changes/fixies into:
>   perf tools: Add perf data to CTF convertion support
> 
> if we could break the last one into more logical changes
> it'd be nicer.. but if not, let's got from here
> 
> I'll prepare those 1st 3 patches.. and review your code while
> getting familiar with ctf again ;-)

Okay. I rebased and re-pushed perf_ctf_3. It is down to 3 + 2
patches. Can merge the last two patches into one.

> thanks,
> jirka

Sebastian