From: Tanay Abhra <tanayabh@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>, Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] config.c: change the function signature of `git_config_string()`
Date: Tue, 22 Jul 2014 17:18:38 +0530 [thread overview]
Message-ID: <53CE4F96.3000409@gmail.com> (raw)
In-Reply-To: <vpqsiltsjm7.fsf@anie.imag.fr>
On 7/22/2014 5:14 PM, Matthieu Moy wrote:
> Jeff King <peff@peff.net> writes:
>
>> will complain that we are passing a pointer to "const char *", not a
>> pointer to "char *". And indeed, compiling with your patch introduces a
>> ton of compiler warnings.
>
> Tanay: are you not compiling with gcc -Wall -Werror?
>
> (see my earlier message, just create a file config.mak containing
>
> CFLAGS += -Wdeclaration-after-statement -Wall -Werror
>
> )
>
Yes, I was. Dunno why it didn't work then.
next prev parent reply other threads:[~2014-07-22 11:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 10:49 [PATCH] config.c: change the function signature of `git_config_string()` Tanay Abhra
2014-07-22 11:07 ` Jeff King
2014-07-22 11:41 ` Tanay Abhra
2014-07-22 11:44 ` Matthieu Moy
2014-07-22 11:48 ` Tanay Abhra [this message]
2014-07-22 15:53 ` Junio C Hamano
2014-07-22 16:03 ` Matthieu Moy
2014-07-22 16:47 ` Junio C Hamano
2014-07-23 8:42 ` Matthieu Moy
2014-07-23 17:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CE4F96.3000409@gmail.com \
--to=tanayabh@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.