Re: [libsocketcan 2/2] Update can_set_ctrlmode() documentation

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

On 07/21/2014 11:43 AM, Nikita Edward Baruzdin wrote:
> Signed-off-by: Nikita Edward Baruzdin <nebaruzdin@gmail.com>
> ---
>  src/libsocketcan.c | 33 +++++++++++++++------------------
>  1 file changed, 15 insertions(+), 18 deletions(-)
> 
> diff --git a/src/libsocketcan.c b/src/libsocketcan.c
> index fe3a0b3..21884b6 100644
> --- a/src/libsocketcan.c
> +++ b/src/libsocketcan.c
> @@ -774,13 +774,20 @@ int can_set_restart_ms(const char *name, __u32 restart_ms)
>   *
>   * @param cm pointer of a can_ctrlmode struct
>   *
> - * This sets the control mode of the can device. There're currently three
> - * different control modes:
> - * - LOOPBACK
> - * - LISTEN_ONLY
> - * - TRIPPLE_SAMPLING
> + * This sets the control mode of the can device. There are currently the
> + * following modes available (each mapped to its own macro):
>   *
> - * You have to define the control mode struct yourself. a can_ctrlmode struct
> + * @code
> + * #define CAN_CTRLMODE_LOOPBACK           0x01    /* Loopback mode */

Have you actually compile-tested this change?

> libsocketcan.c:781:52: warning: "/*" within comment [-Wcomment]
>   * #define CAN_CTRLMODE_LOOPBACK           0x01    /* Loopback mode */

...and it finally fails to build from source. I've fixed this while
applying the patch.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]