Re: [Qemu-devel] [PATCH v2 1/2] qemu-img: Allow source cache mode specification

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

On 07/22/2014 02:58 PM, Max Reitz wrote:
> Many qemu-img subcommands only read the source file(s) once. For these
> use cases, a full write-back cache is unnecessary and mainly clutters
> host cache memory. Though this is generally no concern as cache memory
> is freely available and can be scaled by the host OS, it may become a
> concern with thin provisioning.
> 
> For these cases, it makes sense to allow users to freely specify the
> source cache mode (e.g. use no cache at all).
> 
> This commit adds a new switch (-T) for the qemu-img subcommands check,
> compare, convert and rebase to specify the cache to be used for source
> images (the backing file in case of rebase).
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  qemu-img-cmds.hx | 16 ++++++------
>  qemu-img.c       | 78 ++++++++++++++++++++++++++++++++++++++++++++------------
>  qemu-img.texi    | 14 +++++++---
>  3 files changed, 80 insertions(+), 28 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]