diff for duplicates of <53CED5D9.9010609@suse.de> diff --git a/a/1.txt b/N1/1.txt index 91e6697..f4731b2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -82,12 +82,12 @@ On 21.07.14 11:59, mihai.caraman@freescale.com wrote: >>>> + >>>> + /* Load the instruction manually if it failed to do so in the >>>> + * exit path */ ->>>> + if (vcpu->arch.last_inst = KVM_INST_FETCH_FAILED) +>>>> + if (vcpu->arch.last_inst == KVM_INST_FETCH_FAILED) >>>> + ret = kvmppc_load_last_inst(vcpu, type, &vcpu- >>>> arch.last_inst); >>>> + >>>> + ->>>> + *inst = (ret = EMULATE_DONE && kvmppc_need_byteswap(vcpu)) ? +>>>> + *inst = (ret == EMULATE_DONE && kvmppc_need_byteswap(vcpu)) ? >>>> + swab32(vcpu->arch.last_inst) : vcpu->arch.last_inst; >>> This makes even less sense than the previous version. Either you treat >>> inst as "definitely overwritten" or as "preserves previous data on diff --git a/a/content_digest b/N1/content_digest index 6dd7ed7..b6a91cc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,11 +5,11 @@ "ref\032d95c415b3f4a69bebd5a208c498e15@BY2PR03MB508.namprd03.prod.outlook.com\0" "From\0Alexander Graf <agraf@suse.de>\0" "Subject\0Re: [PATCH v5 4/5] KVM: PPC: Alow kvmppc_get_last_inst() to fail\0" - "Date\0Tue, 22 Jul 2014 21:21:29 +0000\0" + "Date\0Tue, 22 Jul 2014 23:21:29 +0200\0" "To\0mihai.caraman@freescale.com <mihai.caraman@freescale.com>\0" - "Cc\0kvm-ppc@vger.kernel.org <kvm-ppc@vger.kernel.org>" - linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> - " kvm@vger.kernel.org <kvm@vger.kernel.org>\0" + "Cc\0linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org>" + kvm@vger.kernel.org <kvm@vger.kernel.org> + " kvm-ppc@vger.kernel.org <kvm-ppc@vger.kernel.org>\0" "\00:1\0" "b\0" "\n" @@ -96,12 +96,12 @@ ">>>> +\n" ">>>> +\t/* Load the instruction manually if it failed to do so in the\n" ">>>> +\t * exit path */\n" - ">>>> +\tif (vcpu->arch.last_inst = KVM_INST_FETCH_FAILED)\n" + ">>>> +\tif (vcpu->arch.last_inst == KVM_INST_FETCH_FAILED)\n" ">>>> +\t\tret = kvmppc_load_last_inst(vcpu, type, &vcpu-\n" ">>>> arch.last_inst);\n" ">>>> +\n" ">>>> +\n" - ">>>> +\t*inst = (ret = EMULATE_DONE && kvmppc_need_byteswap(vcpu)) ?\n" + ">>>> +\t*inst = (ret == EMULATE_DONE && kvmppc_need_byteswap(vcpu)) ?\n" ">>>> +\t\tswab32(vcpu->arch.last_inst) : vcpu->arch.last_inst;\n" ">>> This makes even less sense than the previous version. Either you treat\n" ">>> inst as \"definitely overwritten\" or as \"preserves previous data on\n" @@ -129,4 +129,4 @@ "\n" Alex -d821409089786890ba163c4e0aa4493b7aa1bf07a89256aac4d1f6ca0a4d15ee +1f6d7f48373b3faaaaaab5681b3236321d025cad503b3d30fdbcdc45b3dabe85
diff --git a/a/1.txt b/N2/1.txt index 91e6697..f4731b2 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -82,12 +82,12 @@ On 21.07.14 11:59, mihai.caraman@freescale.com wrote: >>>> + >>>> + /* Load the instruction manually if it failed to do so in the >>>> + * exit path */ ->>>> + if (vcpu->arch.last_inst = KVM_INST_FETCH_FAILED) +>>>> + if (vcpu->arch.last_inst == KVM_INST_FETCH_FAILED) >>>> + ret = kvmppc_load_last_inst(vcpu, type, &vcpu- >>>> arch.last_inst); >>>> + >>>> + ->>>> + *inst = (ret = EMULATE_DONE && kvmppc_need_byteswap(vcpu)) ? +>>>> + *inst = (ret == EMULATE_DONE && kvmppc_need_byteswap(vcpu)) ? >>>> + swab32(vcpu->arch.last_inst) : vcpu->arch.last_inst; >>> This makes even less sense than the previous version. Either you treat >>> inst as "definitely overwritten" or as "preserves previous data on diff --git a/a/content_digest b/N2/content_digest index 6dd7ed7..502a174 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -5,7 +5,7 @@ "ref\032d95c415b3f4a69bebd5a208c498e15@BY2PR03MB508.namprd03.prod.outlook.com\0" "From\0Alexander Graf <agraf@suse.de>\0" "Subject\0Re: [PATCH v5 4/5] KVM: PPC: Alow kvmppc_get_last_inst() to fail\0" - "Date\0Tue, 22 Jul 2014 21:21:29 +0000\0" + "Date\0Tue, 22 Jul 2014 23:21:29 +0200\0" "To\0mihai.caraman@freescale.com <mihai.caraman@freescale.com>\0" "Cc\0kvm-ppc@vger.kernel.org <kvm-ppc@vger.kernel.org>" linuxppc-dev@lists.ozlabs.org <linuxppc-dev@lists.ozlabs.org> @@ -96,12 +96,12 @@ ">>>> +\n" ">>>> +\t/* Load the instruction manually if it failed to do so in the\n" ">>>> +\t * exit path */\n" - ">>>> +\tif (vcpu->arch.last_inst = KVM_INST_FETCH_FAILED)\n" + ">>>> +\tif (vcpu->arch.last_inst == KVM_INST_FETCH_FAILED)\n" ">>>> +\t\tret = kvmppc_load_last_inst(vcpu, type, &vcpu-\n" ">>>> arch.last_inst);\n" ">>>> +\n" ">>>> +\n" - ">>>> +\t*inst = (ret = EMULATE_DONE && kvmppc_need_byteswap(vcpu)) ?\n" + ">>>> +\t*inst = (ret == EMULATE_DONE && kvmppc_need_byteswap(vcpu)) ?\n" ">>>> +\t\tswab32(vcpu->arch.last_inst) : vcpu->arch.last_inst;\n" ">>> This makes even less sense than the previous version. Either you treat\n" ">>> inst as \"definitely overwritten\" or as \"preserves previous data on\n" @@ -129,4 +129,4 @@ "\n" Alex -d821409089786890ba163c4e0aa4493b7aa1bf07a89256aac4d1f6ca0a4d15ee +41bf197e9b05a51447e0d09a358682cbe0a6836fafc3f40d18d2904309d9d687
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.