Re: [PATCH RESEND 1/4] btrfs-progs: Check fstype in find_mount_root()

[Qu Wenruo <quwenruo@cn.fujitsu.com>]

David, thanks for all the comments about the 'fi di' related patchset.

-------- Original Message --------
Subject: Re: [PATCH RESEND 1/4] btrfs-progs: Check fstype in 
find_mount_root()
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Date: 2014年07月23日 03:15
> On Thu, Jul 10, 2014 at 11:05:10AM +0800, Qu Wenruo wrote:
>> When calling find_mount_root(), caller in fact wants to find the mount
>> point of *BTRFS*.
>>
>> So also check ent->fstype in find_mount_root() and output proper error
>> messages if needed.
> The utils.c functions should be mostly silent about the errors as this
> this the common code and it's up to the callers to print the messages.
> The existing printf in find_mount_root had appeared before the function
> was moved to utils.c.
Thanks for the info about convention in utils.c
I'll update the patch and remove the printf from the original codes and 
my patches.

>
>> This will suppress a lot of "Inapproiate ioctl for device" error
>> message.
> Catching the error early is a good thing of course.
BTW, I did not see the patchset the latest integration branch, so after 
all the update about the patchset,
should I resend the patchset rebased on the latest integration branch?

Thanks,
Qu.