All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikhail Ilin <m.ilin@samsung.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org,
	'Yury Gribov' <y.gribov@samsung.com>,
	Slava Garbuzov <v.garbuzov@samsung.com>
Subject: Re: [Qemu-devel] [Bug 1346769] Re: /proc/self/maps content returned to 32-bits guest under 64-bits qemu
Date: Wed, 23 Jul 2014 09:04:56 +0400	[thread overview]
Message-ID: <53CF4278.7070101@samsung.com> (raw)
In-Reply-To: <20140722085151.9110.11343.malone@gac.canonical.com>

On 22.07.2014 12:51, Peter Maydell wrote:
 > I think the ifdefs are just accident of history and we can safely remove
 > them.
 >

Good, let make a fix.

 From 719f4e66b134a043dabdf5f6cb6d40445a53e071 Mon Sep 17 00:00:00 2001
From: Mikhail Ilyin <m.ilin@samsung.com>
Date: Wed, 23 Jul 2014 08:49:09 +0400
Subject: [PATCH] Remove target specific ifdefs which are not relevant 
any more.

Signed-off-by: Mikhail Ilyin <m.ilin@samsung.com>
---
  linux-user/syscall.c | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a50229d..09bbc44 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5092,10 +5092,8 @@ static int open_self_cmdline(void *cpu_env, int fd)

  static int open_self_maps(void *cpu_env, int fd)
  {
-#if defined(TARGET_ARM) || defined(TARGET_M68K) || 
defined(TARGET_UNICORE32)
      CPUState *cpu = ENV_GET_CPU((CPUArchState *)cpu_env);
      TaskState *ts = cpu->opaque;
-#endif
      FILE *fp;
      char *line = NULL;
      size_t len = 0;
@@ -5133,13 +5131,11 @@ static int open_self_maps(void *cpu_env, int fd)
      free(line);
      fclose(fp);

-#if defined(TARGET_ARM) || defined(TARGET_M68K) || 
defined(TARGET_UNICORE32)
      dprintf(fd, "%08llx-%08llx rw-p %08llx 00:00 0          [stack]\n",
                  (unsigned long long)ts->info->stack_limit,
                  (unsigned long long)(ts->info->start_stack +
                                       (TARGET_PAGE_SIZE - 1)) & 
TARGET_PAGE_MASK,
                  (unsigned long long)0);
-#endif

      return 0;
  }
-- 
1.9.1

  reply	other threads:[~2014-07-23  5:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22  6:47 [Qemu-devel] [Bug 1346769] [NEW] /proc/self/maps content returned to 32-bits guest under 64-bits qemu Mikhail Ilyin
2014-07-22  8:51 ` [Qemu-devel] [Bug 1346769] " Peter Maydell
2014-07-23  5:04   ` Mikhail Ilin [this message]
2014-07-23  5:23     ` Mikhail Ilin
2016-06-17 16:05 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CF4278.7070101@samsung.com \
    --to=m.ilin@samsung.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=v.garbuzov@samsung.com \
    --cc=y.gribov@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.