From: takahiro.akashi@linaro.org (AKASHI Takahiro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 0/3] arm64: Add seccomp support
Date: Wed, 23 Jul 2014 16:09:18 +0900 [thread overview]
Message-ID: <53CF5F9E.4020404@linaro.org> (raw)
In-Reply-To: <CAGXu5j+1huPbBKH25HK6PmAL3Mi-zgD5UDRp-6wx8vuPVOBDEg@mail.gmail.com>
On 07/23/2014 05:16 AM, Kees Cook wrote:
> On Tue, Jul 22, 2014 at 2:14 AM, AKASHI Takahiro
> <takahiro.akashi@linaro.org> wrote:
>> (Please apply this patch after my audit patch in order to avoid some
>> conflict on arm64/Kconfig.)
>>
>> This patch enables secure computing (system call filtering) on arm64.
>> System calls can be allowed or denied by loaded bpf-style rules.
>> Architecture specific part is to run secure_computing() on syscall entry
>> and check the result. See [3/3]
>
> Thanks for working on this!
>
>> Prerequisites are:
>> * "arm64: Add audit support" patch
>>
>> This code is tested on ARMv8 fast model using
>> * libseccomp v2.1.1 with modifications for arm64 and verified by its "live"
>> tests, 20, 21 and 24.
>> * modified version of Kees' seccomp test for 'changing/skipping a syscall'
>> behavior
>
> Would you be able to share this? I'd love to add it to the seccomp
> regression suite for the arm64-specific parts.
Yep, I forked your repo here:
https://github.com/t-akashi/seccomp.git
(See trace_arm64 branch)
Thanks,
-Takahiro AKASHI
> Thanks!
>
> -Kees
>
>>
>> Changes v4 -> v5:
>> * rebased to v3.16-rc
>> * add patch [1/3] to allow ptrace to change a system call
>> (please note that this patch should be applied even without seccomp.)
>>
>> Changes v3 -> v4:
>> * removed the following patch and moved it to "arm64: prerequisites for
>> audit and ftrace" patchset since it is required for audit and ftrace in
>> case of !COMPAT, too.
>> "arm64: is_compat_task is defined both in asm/compat.h and linux/compat.h"
>>
>> Changes v2 -> v3:
>> * removed unnecessary 'type cast' operations [2/3]
>> * check for a return value (-1) of secure_computing() explicitly [2/3]
>> * aligned with the patch, "arm64: split syscall_trace() into separate
>> functions for enter/exit" [2/3]
>> * changed default of CONFIG_SECCOMP to n [2/3]
>>
>> Changes v1 -> v2:
>> * added generic seccomp.h for arm64 to utilize it [1,2/3]
>> * changed syscall_trace() to return more meaningful value (-EPERM)
>> on seccomp failure case [2/3]
>> * aligned with the change in "arm64: make a single hook to syscall_trace()
>> for all syscall features" v2 [2/3]
>> * removed is_compat_task() definition from compat.h [3/3]
>>
>> AKASHI Takahiro (3):
>> arm64: ptrace: reload a syscall number after ptrace operations
>> asm-generic: Add generic seccomp.h for secure computing mode 1
>> arm64: Add seccomp support
>>
>> arch/arm64/Kconfig | 14 ++++++++++++++
>> arch/arm64/include/asm/seccomp.h | 25 +++++++++++++++++++++++++
>> arch/arm64/include/asm/unistd.h | 3 +++
>> arch/arm64/kernel/entry.S | 2 ++
>> arch/arm64/kernel/ptrace.c | 18 ++++++++++++++++++
>> include/asm-generic/seccomp.h | 28 ++++++++++++++++++++++++++++
>> 6 files changed, 90 insertions(+)
>> create mode 100644 arch/arm64/include/asm/seccomp.h
>> create mode 100644 include/asm-generic/seccomp.h
>>
>> --
>> 1.7.9.5
>>
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Kees Cook <keescook@chromium.org>
Cc: Will Drewry <wad@chromium.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
dsaxena@linaro.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linaro-kernel@lists.linaro.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 0/3] arm64: Add seccomp support
Date: Wed, 23 Jul 2014 16:09:18 +0900 [thread overview]
Message-ID: <53CF5F9E.4020404@linaro.org> (raw)
In-Reply-To: <CAGXu5j+1huPbBKH25HK6PmAL3Mi-zgD5UDRp-6wx8vuPVOBDEg@mail.gmail.com>
On 07/23/2014 05:16 AM, Kees Cook wrote:
> On Tue, Jul 22, 2014 at 2:14 AM, AKASHI Takahiro
> <takahiro.akashi@linaro.org> wrote:
>> (Please apply this patch after my audit patch in order to avoid some
>> conflict on arm64/Kconfig.)
>>
>> This patch enables secure computing (system call filtering) on arm64.
>> System calls can be allowed or denied by loaded bpf-style rules.
>> Architecture specific part is to run secure_computing() on syscall entry
>> and check the result. See [3/3]
>
> Thanks for working on this!
>
>> Prerequisites are:
>> * "arm64: Add audit support" patch
>>
>> This code is tested on ARMv8 fast model using
>> * libseccomp v2.1.1 with modifications for arm64 and verified by its "live"
>> tests, 20, 21 and 24.
>> * modified version of Kees' seccomp test for 'changing/skipping a syscall'
>> behavior
>
> Would you be able to share this? I'd love to add it to the seccomp
> regression suite for the arm64-specific parts.
Yep, I forked your repo here:
https://github.com/t-akashi/seccomp.git
(See trace_arm64 branch)
Thanks,
-Takahiro AKASHI
> Thanks!
>
> -Kees
>
>>
>> Changes v4 -> v5:
>> * rebased to v3.16-rc
>> * add patch [1/3] to allow ptrace to change a system call
>> (please note that this patch should be applied even without seccomp.)
>>
>> Changes v3 -> v4:
>> * removed the following patch and moved it to "arm64: prerequisites for
>> audit and ftrace" patchset since it is required for audit and ftrace in
>> case of !COMPAT, too.
>> "arm64: is_compat_task is defined both in asm/compat.h and linux/compat.h"
>>
>> Changes v2 -> v3:
>> * removed unnecessary 'type cast' operations [2/3]
>> * check for a return value (-1) of secure_computing() explicitly [2/3]
>> * aligned with the patch, "arm64: split syscall_trace() into separate
>> functions for enter/exit" [2/3]
>> * changed default of CONFIG_SECCOMP to n [2/3]
>>
>> Changes v1 -> v2:
>> * added generic seccomp.h for arm64 to utilize it [1,2/3]
>> * changed syscall_trace() to return more meaningful value (-EPERM)
>> on seccomp failure case [2/3]
>> * aligned with the change in "arm64: make a single hook to syscall_trace()
>> for all syscall features" v2 [2/3]
>> * removed is_compat_task() definition from compat.h [3/3]
>>
>> AKASHI Takahiro (3):
>> arm64: ptrace: reload a syscall number after ptrace operations
>> asm-generic: Add generic seccomp.h for secure computing mode 1
>> arm64: Add seccomp support
>>
>> arch/arm64/Kconfig | 14 ++++++++++++++
>> arch/arm64/include/asm/seccomp.h | 25 +++++++++++++++++++++++++
>> arch/arm64/include/asm/unistd.h | 3 +++
>> arch/arm64/kernel/entry.S | 2 ++
>> arch/arm64/kernel/ptrace.c | 18 ++++++++++++++++++
>> include/asm-generic/seccomp.h | 28 ++++++++++++++++++++++++++++
>> 6 files changed, 90 insertions(+)
>> create mode 100644 arch/arm64/include/asm/seccomp.h
>> create mode 100644 include/asm-generic/seccomp.h
>>
>> --
>> 1.7.9.5
>>
>
>
>
next prev parent reply other threads:[~2014-07-23 7:09 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 9:14 [PATCH v5 0/3] arm64: Add seccomp support AKASHI Takahiro
2014-07-22 9:14 ` AKASHI Takahiro
2014-07-22 9:14 ` [PATCH v5 1/3] arm64: ptrace: reload a syscall number after ptrace operations AKASHI Takahiro
2014-07-22 9:14 ` AKASHI Takahiro
2014-07-22 20:15 ` Kees Cook
2014-07-22 20:15 ` Kees Cook
2014-07-23 7:03 ` AKASHI Takahiro
2014-07-23 7:03 ` AKASHI Takahiro
2014-07-23 8:25 ` Will Deacon
2014-07-23 8:25 ` Will Deacon
2014-07-23 9:09 ` AKASHI Takahiro
2014-07-23 9:09 ` AKASHI Takahiro
2014-07-23 15:13 ` Kees Cook
2014-07-23 15:13 ` Kees Cook
2014-07-24 3:54 ` Andy Lutomirski
2014-07-24 3:54 ` Andy Lutomirski
2014-07-24 5:57 ` AKASHI Takahiro
2014-07-24 5:57 ` AKASHI Takahiro
2014-07-24 15:01 ` Andy Lutomirski
2014-07-24 15:01 ` Andy Lutomirski
2014-07-25 10:36 ` AKASHI Takahiro
2014-07-25 10:36 ` AKASHI Takahiro
2014-07-25 11:03 ` Will Deacon
2014-07-25 11:03 ` Will Deacon
2014-07-29 6:49 ` AKASHI Takahiro
2014-07-29 6:49 ` AKASHI Takahiro
2014-07-29 13:26 ` Will Deacon
2014-07-29 13:26 ` Will Deacon
2014-07-22 9:14 ` [PATCH v5 2/3] asm-generic: Add generic seccomp.h for secure computing mode 1 AKASHI Takahiro
2014-07-22 9:14 ` AKASHI Takahiro
2014-07-24 3:40 ` Andy Lutomirski
2014-07-24 3:40 ` Andy Lutomirski
2014-07-24 4:41 ` Kees Cook
2014-07-24 4:41 ` Kees Cook
2014-07-24 5:17 ` AKASHI Takahiro
2014-07-24 5:17 ` AKASHI Takahiro
2014-07-24 14:57 ` Andy Lutomirski
2014-07-24 14:57 ` Andy Lutomirski
2014-07-25 8:52 ` AKASHI Takahiro
2014-07-25 8:52 ` AKASHI Takahiro
2014-07-22 9:14 ` [PATCH v5 3/3] arm64: Add seccomp support AKASHI Takahiro
2014-07-22 9:14 ` AKASHI Takahiro
2014-07-24 3:52 ` Andy Lutomirski
2014-07-24 3:52 ` Andy Lutomirski
2014-07-24 5:40 ` AKASHI Takahiro
2014-07-24 5:40 ` AKASHI Takahiro
2014-07-24 15:00 ` Andy Lutomirski
2014-07-24 15:00 ` Andy Lutomirski
2014-07-24 15:16 ` Catalin Marinas
2014-07-24 15:16 ` Catalin Marinas
2014-07-25 9:37 ` AKASHI Takahiro
2014-07-25 9:37 ` AKASHI Takahiro
2014-08-05 15:08 ` Kees Cook
2014-08-05 15:08 ` Kees Cook
2014-08-08 7:35 ` AKASHI Takahiro
2014-08-08 7:35 ` AKASHI Takahiro
2014-08-11 9:24 ` Will Deacon
2014-08-11 9:24 ` Will Deacon
2014-08-12 6:57 ` AKASHI Takahiro
2014-08-12 6:57 ` AKASHI Takahiro
2014-08-12 9:40 ` Will Deacon
2014-08-12 9:40 ` Will Deacon
2014-08-12 11:17 ` AKASHI Takahiro
2014-08-12 11:17 ` AKASHI Takahiro
2014-08-15 14:33 ` Will Deacon
2014-08-15 14:33 ` Will Deacon
2014-07-22 20:16 ` [PATCH v5 0/3] " Kees Cook
2014-07-22 20:16 ` Kees Cook
2014-07-23 7:09 ` AKASHI Takahiro [this message]
2014-07-23 7:09 ` AKASHI Takahiro
2014-07-23 15:36 ` Kees Cook
2014-07-23 15:36 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CF5F9E.4020404@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.