All of lore.kernel.org
 help / color / mirror / Atom feed
From: cyrille.pitchen@atmel.com (Cyrille Pitchen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] net/macb: add scatter-gather hw feature
Date: Wed, 23 Jul 2014 09:45:12 +0200	[thread overview]
Message-ID: <53CF6808.4070206@atmel.com> (raw)
In-Reply-To: <20140720.211337.211665722122921773.davem@davemloft.net>

Le 21/07/2014 06:13, David Miller a ?crit :
> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Date: Fri, 18 Jul 2014 16:21:14 +0200
> 
>> +		if (tx_skb->mapped_as_page) {
>> +			dma_unmap_page(&bp->pdev->dev, tx_skb->mapping,
>> +				       tx_skb->size, DMA_TO_DEVICE);
>> +		} else {
>> +			dma_unmap_single(&bp->pdev->dev, tx_skb->mapping,
>> +					 tx_skb->size, DMA_TO_DEVICE);
>> +		}
> 
> Please do not use curly braces for basic block composed of a single statement.
> 
Hi David,

thanks for your review, I'll fix it in the next series of patch.

Regards,

Cyrille

WARNING: multiple messages have this Message-ID (diff)
From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
To: David Miller <davem@davemloft.net>
Cc: <nicolas.ferre@atmel.com>, <linux-arm-kernel@lists.infradead.org>,
	<netdev@vger.kernel.org>, <soren.brinkmann@xilinx.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] net/macb: add scatter-gather hw feature
Date: Wed, 23 Jul 2014 09:45:12 +0200	[thread overview]
Message-ID: <53CF6808.4070206@atmel.com> (raw)
In-Reply-To: <20140720.211337.211665722122921773.davem@davemloft.net>

Le 21/07/2014 06:13, David Miller a écrit :
> From: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Date: Fri, 18 Jul 2014 16:21:14 +0200
> 
>> +		if (tx_skb->mapped_as_page) {
>> +			dma_unmap_page(&bp->pdev->dev, tx_skb->mapping,
>> +				       tx_skb->size, DMA_TO_DEVICE);
>> +		} else {
>> +			dma_unmap_single(&bp->pdev->dev, tx_skb->mapping,
>> +					 tx_skb->size, DMA_TO_DEVICE);
>> +		}
> 
> Please do not use curly braces for basic block composed of a single statement.
> 
Hi David,

thanks for your review, I'll fix it in the next series of patch.

Regards,

Cyrille

  reply	other threads:[~2014-07-23  7:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 14:21 [PATCH 0/6] net/macb: add HW features to macb driver Cyrille Pitchen
2014-07-18 14:21 ` Cyrille Pitchen
2014-07-18 14:21 ` Cyrille Pitchen
2014-07-18 14:21 ` [PATCH 1/6] net/macb: configure for FIFO mode and non-gigabit Cyrille Pitchen
2014-07-18 14:21   ` Cyrille Pitchen
2014-07-21  4:12   ` David Miller
2014-07-21  4:12     ` David Miller
2014-07-18 14:21 ` [PATCH 2/6] net/macb: add scatter-gather hw feature Cyrille Pitchen
2014-07-18 14:21   ` Cyrille Pitchen
2014-07-18 14:21   ` Cyrille Pitchen
2014-07-21  4:13   ` David Miller
2014-07-21  4:13     ` David Miller
2014-07-23  7:45     ` Cyrille Pitchen [this message]
2014-07-23  7:45       ` Cyrille Pitchen
2014-07-18 14:21 ` [PATCH 3/6] net/macb: add TX checksum offload feature Cyrille Pitchen
2014-07-18 14:21   ` Cyrille Pitchen
2014-07-18 14:21   ` Cyrille Pitchen
2014-07-18 14:21 ` [PATCH 4/6] net/macb: add RX " Cyrille Pitchen
2014-07-18 14:21   ` Cyrille Pitchen
2014-07-18 15:36   ` Eric Dumazet
2014-07-18 15:36     ` Eric Dumazet
2014-07-22 16:27     ` Cyrille Pitchen
2014-07-22 16:27       ` Cyrille Pitchen
2014-07-22 16:39       ` Florian Fainelli
2014-07-22 16:39         ` Florian Fainelli
2014-07-22 22:58       ` Eric Dumazet
2014-07-22 22:58         ` Eric Dumazet
2014-07-24 11:59         ` Cyrille Pitchen
2014-07-24 11:59           ` Cyrille Pitchen
2014-07-18 14:32 ` [PATCH 5/6] ARM: at91: change compatibility string for sama5d3x gem Cyrille Pitchen
2014-07-18 14:32   ` Cyrille Pitchen
2014-07-18 14:32 ` [PATCH 6/6] net/macb: enable scatter-gather feature and set DMA burst length for sama5d4 gem Cyrille Pitchen
2014-07-18 14:32   ` Cyrille Pitchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CF6808.4070206@atmel.com \
    --to=cyrille.pitchen@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.