From: Anand Jain <Anand.Jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RFC] btrfs: code optimize use btrfs_get_bdev_and_sb() at btrfs_scan_one_device
Date: Wed, 23 Jul 2014 17:11:29 +0800 [thread overview]
Message-ID: <53CF7C41.5050408@oracle.com> (raw)
In-Reply-To: <20140722174241.GC1553@twin.jikos.cz>
On 07/23/2014 01:42 AM, David Sterba wrote:
> On Tue, Jul 08, 2014 at 02:38:37AM +0800, Anand Jain wrote:
>> (for review comments pls).
>>
>> btrfs_scan_one_device() needs SB, instead of doing it from scratch could
>> use btrfs_get_bdev_and_sb()
>
> Please see
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6f60cbd3ae442cb35861bb522f388db123d42ec1
>
> your patch actually reverts the changes. btrfs_get_bdev_and_sb does not
> work and it was a pretty nasty bug, we've spent a long afternoon
> catching it.
Ah! It explains why we had a different btrfs_read_dev_super().
Thanks.
Anand
prev parent reply other threads:[~2014-07-23 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 18:38 [PATCH RFC] btrfs: code optimize use btrfs_get_bdev_and_sb() at btrfs_scan_one_device Anand Jain
2014-07-08 3:34 ` Miao Xie
2014-07-08 4:08 ` Liu Bo
2014-07-08 4:24 ` Miao Xie
2014-07-22 17:42 ` David Sterba
2014-07-23 9:11 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CF7C41.5050408@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.