From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60650)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X9sg7-00022C-Ur
	for qemu-devel@nongnu.org; Wed, 23 Jul 2014 05:17:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X9sg1-0000sB-Vg
	for qemu-devel@nongnu.org; Wed, 23 Jul 2014 05:17:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40348)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1X9sg1-0000s4-Nt
	for qemu-devel@nongnu.org; Wed, 23 Jul 2014 05:17:33 -0400
Message-ID: <53CF7D89.7000001@redhat.com>
Date: Wed, 23 Jul 2014 11:16:57 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1406106691-21912-1-git-send-email-sebastian.tanase@openwide.fr>
In-Reply-To: <1406106691-21912-1-git-send-email-sebastian.tanase@openwide.fr>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] icount: Fix virtual clock start value on
	ARM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Tanase <sebastian.tanase@openwide.fr>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com, afaerber@suse.de, alex@alex.org.uk, mst@redhat.com

Il 23/07/2014 11:11, Sebastian Tanase ha scritto:
> When using the icount option on ARM, the virtual
> clock starts counting at realtime clock but it
> should start at 0.
> This small fix addresses this issue.
> 
> Signed-off-by: Sebastian Tanase <sebastian.tanase@openwide.fr>

Thanks, this is ok for 2.2.

Paolo

> ---
>  cpus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cpus.c b/cpus.c
> index 5e7f2cf..de18ece 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -104,7 +104,7 @@ static bool all_cpu_threads_idle(void)
>  
>  /* Compensate for varying guest execution speed.  */
>  static int64_t qemu_icount_bias;
> -static int64_t vm_clock_warp_start;
> +static int64_t vm_clock_warp_start = -1;
>  /* Conversion factor from emulated instructions to virtual clock ticks.  */
>  static int icount_time_shift;
>  /* Arbitrarily pick 1MIPS as the minimum allowable speed.  */
>