Re: [PATCH v10 3/3] ASoC: fsl: add imx-es8328 machine driver

[Varka Bhadram <varkabhadram-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On 07/23/2014 01:14 PM, Sean Cross wrote:
> +Required properties:
> +- compatible : "fsl,imx-audio-es8328"
> +- model : The user-visible name of this sound complex
> +- ssi-controller : The phandle of the i.MX SSI controller
> +- jack-gpio : Optional GPIO for headphone jack
> +- audio-amp-supply : Power regulator for speaker amps
> +- audio-codec : The phandle of the ES8328 audio codec
> +- audio-routing : A list of the connections between audio components.
> +  Each entry is a pair of strings, the first being the connection's sink,
> +  the second being the connection's source. Valid names could be power
> +  supplies, ES8328 pins, and the jacks on the board:
> +

It would be readable if
Required properties:
- compatible		: "fsl,imx-audio-es8328"
- model			: The user-visible name of this sound complex
- ssi-controller	: The phandle of the i.MX SSI controller
- jack-gpio		: Optional GPIO for headphone jack
...

(...)

> +static int imx_es8328_probe(struct platform_device *pdev)
> +{
> +	struct device_node *np = pdev->dev.of_node;
> +	struct device_node *ssi_np, *codec_np;
> +	struct platform_device *ssi_pdev;
> +	struct imx_es8328_data *data;
> +	u32 int_port, ext_port;
> +	int ret;
> +	struct device *dev = &pdev->dev;
> +
> +	ret = of_property_read_u32(np, "mux-int-port", &int_port);
> +	if (ret) {
> +		dev_err(dev, "mux-int-port missing or invalid\n");
> +		goto fail;
> +	}
> +	if (int_port > MUX_PORT_MAX || int_port == 0) {
> +		dev_err(dev, "mux-int-port: hardware only has %d mux ports\n",
> +				MUX_PORT_MAX);

should match open parenthesis:
	dev_err(dev, "mux-int-port: hardware only has %d mux ports\n",
		MUX_PORT_MAX);

> +		goto fail;
> +	}
> +
> +	ret = of_property_read_u32(np, "mux-ext-port", &ext_port);
> +	if (ret) {
> +		dev_err(dev, "mux-ext-port missing or invalid\n");
> +		goto fail;
> +	}
> +	if (ext_port > MUX_PORT_MAX || ext_port == 0) {
> +		dev_err(dev, "mux-ext-port: hardware only has %d mux ports\n",
> +				MUX_PORT_MAX);

Dto..

(...)

> +static struct platform_driver imx_es8328_driver = {
> +	.driver = {
> +		.name = "imx-es8328",
> +		.owner = THIS_MODULE,

This field updated by module_platform_driver()... No need to do manually..


-- 
Regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html