Re: [PATCH] amd-xgbe: Fix error return code in xgbe_probe()

[Tom Lendacky <thomas.lendacky@amd.com>]

On 07/22/2014 07:59 PM, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the setting real tx queue
> count error handling case instead of 0.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   drivers/net/ethernet/amd/xgbe/xgbe-main.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-main.c b/drivers/net/ethernet/amd/xgbe/xgbe-main.c
> index c83584a..5a1891f 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-main.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-main.c
> @@ -339,7 +339,8 @@ static int xgbe_probe(struct platform_device *pdev)
>   	/* Calculate the number of Tx and Rx rings to be created */
>   	pdata->tx_ring_count = min_t(unsigned int, num_online_cpus(),
>   				     pdata->hw_feat.tx_ch_cnt);
> -	if (netif_set_real_num_tx_queues(netdev, pdata->tx_ring_count)) {
> +	ret = netif_set_real_num_tx_queues(netdev, pdata->tx_ring_count);
> +	if (ret) {
>   		dev_err(dev, "error setting real tx queue count\n");
>   		goto err_io;
>   	}
>