All of lore.kernel.org
 help / color / mirror / Atom feed
From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
To: David Sterba <dsterba@suse.cz>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs-progs: fix build of static target
Date: Thu, 24 Jul 2014 12:22:47 +0900	[thread overview]
Message-ID: <53D07C07.2090302@jp.fujitsu.com> (raw)
In-Reply-To: <1406121381-18611-1-git-send-email-dsterba@suse.cz>

(2014/07/23 22:16), David Sterba wrote:
> A user repoted that static buid fails with
> 
> utils-lib.static.o: In function `arg_strtou64':
> /home/dsterba/labs/btrfs-progs/utils-lib.c:17: multiple definition of `arg_strtou64'
> utils-lib.static.o:/home/dsterba/labs/btrfs-progs/utils-lib.c:17: first defined here
> 
> utils-lib.o was mistakenly added to linker twice.
> 
> Signed-off-by: David Sterba <dsterba@suse.cz>

Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>

> ---
>   Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 8e14d4837520..3853b8734568 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -10,7 +10,7 @@ objects = ctree.o disk-io.o radix-tree.o extent-tree.o print-tree.o \
>   	  root-tree.o dir-item.o file-item.o inode-item.o inode-map.o \
>   	  extent-cache.o extent_io.o volumes.o utils.o repair.o \
>   	  qgroup.o raid6.o free-space-cache.o list_sort.o props.o \
> -	  utils-lib.o ulist.o qgroup-verify.o
> +	  ulist.o qgroup-verify.o
>   cmds_objects = cmds-subvolume.o cmds-filesystem.o cmds-device.o cmds-scrub.o \
>   	       cmds-inspect.o cmds-balance.o cmds-send.o cmds-receive.o \
>   	       cmds-quota.o cmds-qgroup.o cmds-replace.o cmds-check.o \
> 


      reply	other threads:[~2014-07-24  3:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 13:16 [PATCH] btrfs-progs: fix build of static target David Sterba
2014-07-24  3:22 ` Satoru Takeuchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D07C07.2090302@jp.fujitsu.com \
    --to=takeuchi_satoru@jp.fujitsu.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.