From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XAI0m-0000MR-0y
	for qemu-devel@nongnu.org; Thu, 24 Jul 2014 08:20:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XAI0g-0002g8-7Z
	for qemu-devel@nongnu.org; Thu, 24 Jul 2014 08:20:39 -0400
Received: from cantor2.suse.de ([195.135.220.15]:57292 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XAI0f-0002fb-VF
	for qemu-devel@nongnu.org; Thu, 24 Jul 2014 08:20:34 -0400
Message-ID: <53D0FA0F.2030501@suse.de>
Date: Thu, 24 Jul 2014 14:20:31 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1406190486-16026-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA8R-xF+s_t=v92+RR-6E0edUDFMSF+EyaWVLyX2+G1=tw@mail.gmail.com>
In-Reply-To: <CAFEAcA8R-xF+s_t=v92+RR-6E0edUDFMSF+EyaWVLyX2+G1=tw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL for-2.1 0/2] vnc: fix two vnc update issues.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Bruce Rogers <brogers@suse.com>, Stephan Kulow <coolo@suse.de>, Gerd Hoffmann <kraxel@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

Am 24.07.2014 13:48, schrieb Peter Maydell:
> On 24 July 2014 09:28, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>   Hi,
>>
>> Here are two vnc update bugfixes, found by code review while hunting
>> down a issue with vnc updates not being sent to the client.  The
>> original issue has not been root-caused yet, it is also not clear
>> whenever qemu is at fault at all or whenever the vnc updates are
>> stuck somewhere else (kernel network stack).  The bugs found are
>> for real nevertheless, and here are the fixes.
>>
>> please pull,
>>   Gerd
>>
>> The following changes since commit f368c33d5ab09dd5656924185cd975b1183=
8cd25:
>>
>>   Update version for v2.1.0-rc3 release (2014-07-22 18:17:03 +0100)
>>
>> are available in the git repository at:
>>
>>   git://git.kraxel.org/qemu tags/pull-vnc-20140724-1
>>
>> for you to fetch changes up to 832932a6f17983a3167ae9da6fe54a245a30758=
e:
>>
>>   vnc update fix (2014-07-24 10:14:34 +0200)
>>
>> ----------------------------------------------------------------
>> vnc: fix two vnc update issues.
>>
>> ----------------------------------------------------------------
>> Gerd Hoffmann (1):
>>       vnc update fix
>>
>> Stephan Kulow (1):
>>       fix full frame updates for VNC clients
>>
>>  ui/vnc.c | 5 ++++-
>>  ui/vnc.h | 1 +
>>  2 files changed, 5 insertions(+), 1 deletion(-)
>=20
> So are these *really* release critical bugs, if they've been
> only found in code review? We're really close to release now
> and so my preference is not to include changes unless they're
> really necessary...

These are fixing openQA breakage (os-autoinst),

https://bugzilla.novell.com/show_bug.cgi?id=3D888142

so +1 to include them if Gerd is confident they don't regress otherwise.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg