From: Vlastimil Babka <vbabka@suse.cz>
To: Nick Krause <xerofoify@gmail.com>, Sasha Levin <sashal@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
mail@beyermatthias.de, hdegoede@redhat.com,
dan.j.williams@intel.com, valentine.barshak@cogentembedded.com,
Ming Lei <ming.lei@canonical.com>,
Michael Opdenacker <michael.opdenacker@free-electrons.com>,
linux-usb@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb-core: Remove Fix mes in file hcd.c
Date: Thu, 24 Jul 2014 15:07:41 +0200 [thread overview]
Message-ID: <53D1051D.4060204@suse.cz> (raw)
In-Reply-To: <CAPDOMVjezfw36YPaPKSDoFt7Ybmv_a1HFTA25uKh4S6J08wt5w@mail.gmail.com>
On 07/23/2014 05:24 AM, Nick Krause wrote:
> On Tue, Jul 22, 2014 at 8:44 PM, Sasha Levin <sashal@kernel.org> wrote:
>> On 07/18/2014 10:52 PM, Nick Krause wrote:
>>>>> Please explain exactly why it's not needed, why it can never be NULL, and
>>>>> what prevents it from being NULL.
>>>>>
>>>>> "after dicussing" (do you run spellcheck on your mails?) won't mean anything
>>>>> to someone looking at this commit in a year.
>>>>>
>>>>> Your commit message also mentions usb_device which has nothing to do with
>>>>> your patch.
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Sasha
>>>
>>> Sasha ,
>>> Greg seems to have signed it off.
>>> Cheers Nick
>>
>> Greg?
>>
>> Even if the patch is correct (and I'm not saying it is) the commit message is way off.
>>
>>
>> Thanks,
>> Sasha
>
>
> Sasha,
> The patch is in the kernel now.
Greg's tree is not Linus' tree, so it's not set to stone in git commit
history yet.
> I am not going through the trouble of removing
> it, if you want to fix the commit message go on ahead.
> Nick
This kind of attitude might significantly lower your chances of future
patches being accepted.
Vlastimil
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2014-07-24 13:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 17:34 [PATCH] usb-core: Remove Fix mes in file hcd.c Nicholas Krause
2014-07-18 19:09 ` Alan Stern
2014-07-18 19:55 ` Nick Krause
2014-07-19 2:36 ` Sasha Levin
2014-07-19 2:45 ` Nick Krause
2014-07-19 2:52 ` Nick Krause
2014-07-23 0:44 ` Sasha Levin
2014-07-23 3:24 ` Nick Krause
2014-07-24 13:07 ` Vlastimil Babka [this message]
2014-07-24 16:17 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D1051D.4060204@suse.cz \
--to=vbabka@suse.cz \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@beyermatthias.de \
--cc=michael.opdenacker@free-electrons.com \
--cc=ming.lei@canonical.com \
--cc=sashal@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=valentine.barshak@cogentembedded.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.