From: Sasha Levin <sasha.levin@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stern@rowland.harvard.edu, mail@beyermatthias.de,
hdegoede@redhat.com, sarah.a.sharp@linux.intel.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
rostedt@goodmis.org, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c"
Date: Thu, 24 Jul 2014 09:14:49 -0400 [thread overview]
Message-ID: <53D106C9.8070803@oracle.com> (raw)
In-Reply-To: <20140723164910.GA8319@kroah.com>
On 07/23/2014 12:49 PM, Greg KH wrote:
> On Wed, Jul 23, 2014 at 08:56:10AM -0400, Sasha Levin wrote:
>> > Revert since the commit message is incorrect and the original author refuses
>> > to fix/maintain it because "it's in the kernel already".
> How can someone "fix" a commit message that is already in the tree? You
> can't. The code part is correct, so why introduce the issue back?
(I'm not trying to be aggressive, I just think that I misunderstand how this
part of the process works exactly).
I thought we can always edit -next trees? Why do we have to maintain fast forward
on them?
What happens, if for example you take a patch that causes build breakage? Would you
add a revert after that or just yank the commit out of the tree?
If you add a revert and leave the original broken commit in, wouldn't it cause issues
for anyone trying to bisect a build breakage?
Thanks,
Sasha
next prev parent reply other threads:[~2014-07-24 13:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 12:56 [PATCH] usb-core: Revert "usb-core: Remove Fix mes in file hcd.c" Sasha Levin
2014-07-23 16:49 ` Greg KH
2014-07-24 13:14 ` Sasha Levin [this message]
2014-07-24 16:04 ` Greg KH
2014-07-24 16:20 ` Sasha Levin
2014-07-24 20:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D106C9.8070803@oracle.com \
--to=sasha.levin@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@beyermatthias.de \
--cc=rostedt@goodmis.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=sashal@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.