From: Nick Dyer <nick.dyer@itdev.co.uk>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Cc: Yufeng Shen <miletus@chromium.org>,
Benson Leung <bleung@chromium.org>,
Daniel Kurtz <djkurtz@chromium.org>,
Iiro Valkonen <iiro.valkonen@atmel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: atmel_mxt_ts - simplify mxt_initialize a bit
Date: Thu, 24 Jul 2014 16:39:45 +0100 [thread overview]
Message-ID: <53D128C1.9020707@itdev.co.uk> (raw)
In-Reply-To: <20140723215054.GA14362@core.coreip.homeip.net>
On 23/07/14 22:50, Dmitry Torokhov wrote:
> I think having control flow with 2 goto/labels/flags is quite hard to read,
> this version is a bit more readable IMO.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Yes, this looks much clearer to me. Although I can't see anything wrong
looking at it, I think I should probably regression test it for the
different failure paths before it is applied, I will bring it into my series.
prev parent reply other threads:[~2014-07-24 15:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 21:50 [PATCH] Input: atmel_mxt_ts - simplify mxt_initialize a bit Dmitry Torokhov
2014-07-24 15:39 ` Nick Dyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D128C1.9020707@itdev.co.uk \
--to=nick.dyer@itdev.co.uk \
--cc=bleung@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=iiro.valkonen@atmel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miletus@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.