From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH RFC V3 3/5] xen: Force-enable relevant MSR
 events; optimize the number of sent MSR events
Date: Thu, 24 Jul 2014 18:56:38 +0300
Message-ID: <53D12CB6.6090904@bitdefender.com>
References: <1406118884-16628-1-git-send-email-rcojocaru@bitdefender.com>	<1406118884-16628-3-git-send-email-rcojocaru@bitdefender.com>
	<53D13EFC0200007800025A31@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <53D13EFC0200007800025A31@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: kevin.tian@intel.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, eddie.dong@intel.com, xen-devel@lists.xen.org, andres@lagarcavilla.org, jun.nakajima@intel.com, Ian.Jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 07/24/2014 06:14 PM, Jan Beulich wrote:
>>>> On 23.07.14 at 14:34, <rcojocaru@bitdefender.com> wrote:
>> @@ -695,11 +696,34 @@ static void vmx_set_host_env(struct vcpu *v)
>>  void vmx_disable_intercept_for_msr(struct vcpu *v, u32 msr, int type)
>>  {
>>      unsigned long *msr_bitmap = v->arch.hvm_vmx.msr_bitmap;
>> +    struct domain *d = v->domain;
>>  
>>      /* VMX MSR bitmap supported? */
>>      if ( msr_bitmap == NULL )
>>          return;
>>  
>> +    if ( mem_event_check_ring(&d->mem_event->access) )
>> +    {
>> +        /* Filter out MSR-s needed for memory introspection */
>> +        switch ( msr )
>> +        {
>> +        case MSR_IA32_SYSENTER_EIP:
>> +        case MSR_IA32_SYSENTER_ESP:
>> +        case MSR_IA32_SYSENTER_CS:
>> +        case MSR_IA32_MC0_CTL:
>> +        case MSR_STAR:
>> +        case MSR_LSTAR:
>> +
>> +            gdprintk(XENLOG_DEBUG, "MSR 0x%08x "
> 
> Is the current domain/vCPU really useful in this message? And
> do you really need the file name to be printed here? And does the
> MSR number really need to always be 8 characters wide? Or
> perhaps - is this message useful at all?

I thought so, but since it is indeed a minor thing I'll be happy to
remove it.


Thanks,
Razvan Cojocaru