All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: tegra: Use mem size from MC rather than ODMDATA
Date: Thu, 24 Jul 2014 15:00:30 -0600	[thread overview]
Message-ID: <53D173EE.5090905@wwwdotorg.org> (raw)
In-Reply-To: <20140703110121.GG29202@bill-the-cat>

On 07/03/2014 05:01 AM, Tom Rini wrote:
> On Thu, Jul 03, 2014 at 09:45:52AM +0200, Wolfgang Denk wrote:
>> Dear Stephen,
>>
>> In message <53B47F6F.1090405@wwwdotorg.org> you wrote:
>>>
>>>> Is there a specific reason for not using get_ram_size()?
>>>
>>> Since we know the exact RAM size, we may as well simply use it directly
>>> rather than "probing" for it.
>>
>> You _think_ you know the size, but you can never be sure that all this
>> RAM is actually present and working.  There has been many discussions
>> before why using get_ram_size() makes a lot of sense even in fixed
>> size RAM configurations.
>
> Right which is why the flow in this case is:
> 1) Read the place that "knows"
> 2) Pass that size to get_ram_size(), use returned value as what we
> really know the size to be.

Wolfgang, given Tom's explanation, are you now OK with this patch? TomW 
would like clarification?

But to address your points: We really do know that the RAM size is equal 
to what this register says, since at this point in the code, U-Boot is 
already running in RAM (since our HW's boot ROM initializes RAM and 
copies U-Boot to it). Any issues with the RAM itself, either bad HW or 
incorrect configuration, would already have caused a problem just 
executing any code.

  reply	other threads:[~2014-07-24 21:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02 20:12 [U-Boot] [PATCH] ARM: tegra: Use mem size from MC rather than ODMDATA Stephen Warren
2014-07-02 21:18 ` Wolfgang Denk
2014-07-02 21:53   ` Stephen Warren
2014-07-03  7:45     ` Wolfgang Denk
2014-07-03 11:01       ` Tom Rini
2014-07-24 21:00         ` Stephen Warren [this message]
2014-07-31 19:45 ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D173EE.5090905@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.