Re: [PATCH 0/8] tilcdc-panel: Backlight and GPIO devicetree support

[Darren Etheridge <detheridge@ti.com>]

On 07/11/2014 09:18 AM, Ezequiel Garcia wrote:
> Hello all,
>
> This patchset adds the required changes to support an optional backlight
> and GPIO for the tilcdc panel driver.
>
> There was some code to support a backlight, but it was somewhat broken
> and undocumented. I've followed the nice implementation in panel-simple
> and added a similar one here.
>
> The enable GPIO is required to turn on and off devices with such capability.
> Also here, I've followed panel-simple which looks correct.
>
> In addition to this there are very minor cosmetic cleanups and a larger
> error path fix in tilcdc's DRM driver .load error path.
>
> This patchset applies on top of drm-next branch which contains the latest
> tilcdc pushed by Guido.
>
> If at all possible, I'd like to get this merged for v3.17. If a pull request
> is needed, don't hesitate to ask and I'll prepare one.
>
> Comments and tests welcome!
>

All of the changes seem to make sense and I tested on AM335x-EVM both 
with and without the addition "backlight = " in the dts for the panel node.

I see no issues in either case, continued to work as before.

Tested against 3.16-rc6 with this patchset and the earlier patchset from 
Guido applied.

Also tested on BeagleBone Black even though it doesn't have a panel, 
just to make sure nothing changed there.

For the series:
Tested-by: Darren Etheridge <detheridge@ti.com>

> Ezequiel Garcia (8):
>    drm/tilcdc: Fix the error path in tilcdc_load()
>    drm/tilcdc: panel: Add missing of_node_put
>    drm/tilcdc: panel: Remove unused variable
>    drm/tilcdc: panel: Spurious whitespace removal
>    drm/tilcdc: panel: Use devm_kzalloc to simplify the error path
>    drm/tilcdc: panel: Fix backlight devicetree support
>    drm/tilcdc: panel: Set return value explicitly
>    drm/tilcdc: panel: Add support for enable GPIO
>
>   .../devicetree/bindings/drm/tilcdc/panel.txt       |  7 ++
>   drivers/gpu/drm/tilcdc/tilcdc_drv.c                | 60 +++++++++++++++---
>   drivers/gpu/drm/tilcdc/tilcdc_panel.c              | 74 +++++++++++++++++-----
>   3 files changed, 114 insertions(+), 27 deletions(-)
>