All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/radeon: add new info ioctl query for hawaii accel
Date: Fri, 25 Jul 2014 11:05:27 +0900	[thread overview]
Message-ID: <53D1BB67.6080403@daenzer.net> (raw)
In-Reply-To: <1406245907-2567-2-git-send-email-alexander.deucher@amd.com>

On 25.07.2014 08:51, Alex Deucher wrote:
> We need to make sure we have a new enough firmware with
> the fixed nop packet.
> 
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/radeon/radeon_kms.c | 6 ++++++
>  include/uapi/drm/radeon_drm.h       | 1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c
> index 35d9318..3ea9f59 100644
> --- a/drivers/gpu/drm/radeon/radeon_kms.c
> +++ b/drivers/gpu/drm/radeon/radeon_kms.c
> @@ -529,6 +529,12 @@ static int radeon_info_ioctl(struct drm_device *dev, void *data, struct drm_file
>  		else
>  			*value = 1;
>  		break;
> +	case RADEON_INFO_HAWAII_ACCEL:
> +		if (rdev->new_fw)
> +			*value = 1;
> +		else
> +			*value = 0;
> +		break;
>  	default:
>  		DRM_DEBUG_KMS("Invalid request %d\n", info->request);
>  		return -EINVAL;
> diff --git a/include/uapi/drm/radeon_drm.h b/include/uapi/drm/radeon_drm.h
> index 509b2d7..a41dec3 100644
> --- a/include/uapi/drm/radeon_drm.h
> +++ b/include/uapi/drm/radeon_drm.h
> @@ -1010,6 +1010,7 @@ struct drm_radeon_cs {
>  #define RADEON_INFO_VRAM_USAGE		0x1e
>  #define RADEON_INFO_GTT_USAGE		0x1f
>  #define RADEON_INFO_ACTIVE_CU_COUNT	0x20
> +#define RADEON_INFO_HAWAII_ACCEL	0x21
>  
>  struct drm_radeon_info {
>  	uint32_t		request;
> 

Please make the RADEON_INFO_ACCEL_WORKING(2) ioctl do the right thing
for Hawaii instead of adding yet another one.


-- 
Earthling Michel Dänzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer

  reply	other threads:[~2014-07-25  2:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 23:51 [PATCH 1/2] drm/radeon: fix cut and paste issue for hawaii Alex Deucher
2014-07-24 23:51 ` [PATCH 2/2] drm/radeon: add new info ioctl query for hawaii accel Alex Deucher
2014-07-25  2:05   ` Michel Dänzer [this message]
2014-07-25  2:06     ` Michel Dänzer
2014-07-25  2:24       ` Michel Dänzer
2014-07-25  3:05         ` Alex Deucher
2014-07-25  9:30           ` Christian König
2014-07-25 14:14             ` Jerome Glisse
2014-07-27  7:35               ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D1BB67.6080403@daenzer.net \
    --to=michel@daenzer.net \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.