From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Michel_D=E4nzer?= Subject: Re: [PATCH 2/2] drm/radeon: add new info ioctl query for hawaii accel Date: Fri, 25 Jul 2014 11:06:13 +0900 Message-ID: <53D1BB95.5070903@daenzer.net> References: <1406245907-2567-1-git-send-email-alexander.deucher@amd.com> <1406245907-2567-2-git-send-email-alexander.deucher@amd.com> <53D1BB67.6080403@daenzer.net> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id CB7AB6E7B1 for ; Thu, 24 Jul 2014 19:06:17 -0700 (PDT) In-Reply-To: <53D1BB67.6080403@daenzer.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 25.07.2014 11:05, Michel D=E4nzer wrote: > On 25.07.2014 08:51, Alex Deucher wrote: >> We need to make sure we have a new enough firmware with >> the fixed nop packet. >> >> Signed-off-by: Alex Deucher >> --- >> drivers/gpu/drm/radeon/radeon_kms.c | 6 ++++++ >> include/uapi/drm/radeon_drm.h | 1 + >> 2 files changed, 7 insertions(+) >> >> diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeo= n/radeon_kms.c >> index 35d9318..3ea9f59 100644 >> --- a/drivers/gpu/drm/radeon/radeon_kms.c >> +++ b/drivers/gpu/drm/radeon/radeon_kms.c >> @@ -529,6 +529,12 @@ static int radeon_info_ioctl(struct drm_device *dev= , void *data, struct drm_file >> else >> *value =3D 1; >> break; >> + case RADEON_INFO_HAWAII_ACCEL: >> + if (rdev->new_fw) >> + *value =3D 1; >> + else >> + *value =3D 0; >> + break; >> default: >> DRM_DEBUG_KMS("Invalid request %d\n", info->request); >> return -EINVAL; >> diff --git a/include/uapi/drm/radeon_drm.h b/include/uapi/drm/radeon_drm= .h >> index 509b2d7..a41dec3 100644 >> --- a/include/uapi/drm/radeon_drm.h >> +++ b/include/uapi/drm/radeon_drm.h >> @@ -1010,6 +1010,7 @@ struct drm_radeon_cs { >> #define RADEON_INFO_VRAM_USAGE 0x1e >> #define RADEON_INFO_GTT_USAGE 0x1f >> #define RADEON_INFO_ACTIVE_CU_COUNT 0x20 >> +#define RADEON_INFO_HAWAII_ACCEL 0x21 >> = >> struct drm_radeon_info { >> uint32_t request; >> > = > Please make the RADEON_INFO_ACCEL_WORKING(2) ioctl do the right thing > for Hawaii instead of adding yet another one. Ugh, s/ioctl/info query/ of course. -- = Earthling Michel D=E4nzer | http://www.amd.com Libre software enthusiast | Mesa and X developer