From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/2] hwmon: (pwm-fan) Add proper #ifdef CONFIG_OF guard for of_device_id tab
Date: Fri, 25 Jul 2014 04:56:00 +0000 [thread overview]
Message-ID: <53D1E360.6090908@roeck-us.net> (raw)
In-Reply-To: <1406258073.9778.3.camel@phoenix>
On 07/24/2014 09:46 PM, Axel Lin wrote:
> 2014-07-25 12:29 GMT+08:00 Guenter Roeck <linux@roeck-us.net>:
>> On 07/24/2014 08:14 PM, Axel Lin wrote:
>>>
>>> Use of_match_ptr and proper #ifdef CONFIG_OF guard for of_device_id table.
>>> Also makes of_pwm_fan_match const.
>>>
>>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>>
>>
>> The driver won't instantiate if OF is not configured.
> You are right.
> Then how about adding OF dependency to config SENSORS_PWM_FAN?
>
Then it won't compile with allmodconfig on x86. I prefer to be able
to compile it. So we would have to add COMPILE_TEST as secondary
dependency, and things would get more and more complex.
Not really sure if I want to go along that route.
Jean, any thoughts ?
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2014-07-25 4:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 3:14 [lm-sensors] [PATCH 2/2] hwmon: (pwm-fan) Add proper #ifdef CONFIG_OF guard for of_device_id table Axel Lin
2014-07-25 4:29 ` [lm-sensors] [PATCH 2/2] hwmon: (pwm-fan) Add proper #ifdef CONFIG_OF guard for of_device_id tab Guenter Roeck
2014-07-25 4:46 ` Axel Lin
2014-07-25 4:56 ` Guenter Roeck [this message]
2014-07-25 7:50 ` Jean Delvare
2014-07-25 14:05 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D1E360.6090908@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.