From: Richard Henderson <rth@twiddle.net>
To: Jincheng Miao <jmiao@redhat.com>, qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi
Subject: Re: [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep
Date: Thu, 24 Jul 2014 20:58:47 -1000 [thread overview]
Message-ID: <53D20027.7090000@twiddle.net> (raw)
In-Reply-To: <1406263073-635-1-git-send-email-jmiao@redhat.com>
On 07/24/2014 06:37 PM, Jincheng Miao wrote:
> '-singlestep' option will make TB contains only one instruction,
> so that the qemu_log could output trace log when CPU_LOG_EXEC sets,
> and it could help developers to debug control flow.
>
> But currently, in cpu_exec(), it doesn't check singlestep when
> tb_add_jump(), so the TB linked is executed siliently.
> Therefore, this patch adds singlestep check before tb_add_jump().
>
> Signed-off-by: Jincheng Miao <jmiao@redhat.com>
Reasonable. I've been thinking that we simply shoudn't emit goto_tb under
single-step. That does require fixes to all but 2 or 3 of the backends though,
and this patch attacks the problem all in one place.
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2014-07-25 6:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 4:37 [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep Jincheng Miao
2014-07-25 6:58 ` Richard Henderson [this message]
2014-07-25 7:37 ` Peter Maydell
2014-07-25 7:41 ` Richard Henderson
2014-07-25 7:45 ` Peter Maydell
2014-07-25 8:05 ` Jincheng Miao
2014-07-25 12:07 ` Laurent Desnogues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D20027.7090000@twiddle.net \
--to=rth@twiddle.net \
--cc=jmiao@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.