From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAZT2-00030k-5Q for qemu-devel@nongnu.org; Fri, 25 Jul 2014 02:59:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAZSw-0001af-7I for qemu-devel@nongnu.org; Fri, 25 Jul 2014 02:59:00 -0400 Received: from mail-pd0-x231.google.com ([2607:f8b0:400e:c02::231]:52889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAZSv-0001aM-VQ for qemu-devel@nongnu.org; Fri, 25 Jul 2014 02:58:54 -0400 Received: by mail-pd0-f177.google.com with SMTP id p10so5153904pdj.36 for ; Thu, 24 Jul 2014 23:58:52 -0700 (PDT) Sender: Richard Henderson Message-ID: <53D20027.7090000@twiddle.net> Date: Thu, 24 Jul 2014 20:58:47 -1000 From: Richard Henderson MIME-Version: 1.0 References: <1406263073-635-1-git-send-email-jmiao@redhat.com> In-Reply-To: <1406263073-635-1-git-send-email-jmiao@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jincheng Miao , qemu-devel@nongnu.org Cc: riku.voipio@iki.fi On 07/24/2014 06:37 PM, Jincheng Miao wrote: > '-singlestep' option will make TB contains only one instruction, > so that the qemu_log could output trace log when CPU_LOG_EXEC sets, > and it could help developers to debug control flow. > > But currently, in cpu_exec(), it doesn't check singlestep when > tb_add_jump(), so the TB linked is executed siliently. > Therefore, this patch adds singlestep check before tb_add_jump(). > > Signed-off-by: Jincheng Miao Reasonable. I've been thinking that we simply shoudn't emit goto_tb under single-step. That does require fixes to all but 2 or 3 of the backends though, and this patch attacks the problem all in one place. Reviewed-by: Richard Henderson r~