From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?SmnFmcOtIFByY2hhbA==?= Subject: [PATCH] nf: xt_LED: fix too short led-always-blink Date: Fri, 25 Jul 2014 09:21:01 +0200 Message-ID: <53D2055D.3040200@aksignal.cz> References: <53A2AABD.8000109@aksignal.cz> <20140630105419.GA7671@localhost> Reply-To: jiri.prchal@aksignal.cz Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from [188.175.113.102] ([188.175.113.102]:53953 "EHLO router.aksignal.cz" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1759246AbaGYHa6 (ORCPT ); Fri, 25 Jul 2014 03:30:58 -0400 In-Reply-To: Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Bryan Wu , Pablo Neira Ayuso Cc: coreteam@netfilter.org, netfilter-devel@vger.kernel.org, kadlec@blackhole.kfki.hu, kaber@trash.net, Richard Purdie , linux-leds@vger.kernel.org If led-always-blink is set, then between switch led OFF and ON is almost zero time. So blink is invisible. This use oneshot led trigger with fixed time 50ms witch is enough to see blink. Signed-off-by: Jiri --- net/netfilter/xt_LED.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/netfilter/xt_LED.c b/net/netfilter/xt_LED.c index 993de2b..29b5af4 100644 --- a/net/netfilter/xt_LED.c +++ b/net/netfilter/xt_LED.c @@ -55,6 +55,7 @@ led_tg(struct sk_buff *skb, const struct xt_action_param *par) { const struct xt_led_info *ledinfo = par->targinfo; struct xt_led_info_internal *ledinternal = ledinfo->internal_data; + unsigned long t=50; /* always blink 50ms */ /* * If "always blink" is enabled, and there's still some time until the @@ -62,9 +63,10 @@ led_tg(struct sk_buff *skb, const struct xt_action_param *par) */ if ((ledinfo->delay > 0) && ledinfo->always_blink && timer_pending(&ledinternal->timer)) - led_trigger_event(&ledinternal->netfilter_led_trigger, LED_OFF); - - led_trigger_event(&ledinternal->netfilter_led_trigger, LED_FULL); + led_trigger_blink_oneshot(&ledinternal->netfilter_led_trigger, + &t, &t, 1); + else + led_trigger_event(&ledinternal->netfilter_led_trigger, LED_FULL); /* If there's a positive delay, start/update the timer */ if (ledinfo->delay > 0) { -- 1.9.1