Re: [PATCH v4 3/3] CAN: CAN driver to support multiple CAN bus on SPI interface

[Stefano Babic <sbabic@denx.de>]

Hi Varka,


On 24/07/2014 17:14, Varka Bhadram wrote:

>>   In last case CONFIG_OF is not set
>> and a platform device sets the data.
> 
> In our case we can load the driver by DT or Non-DT way.
> 
> If the DT approach is not used means CONFIG_OF is not set. In this case
> the device ids wont be added in the kernel device ids. For this we have
> to define spi_device_ids and update .id_table in struct spi_driver.
> 

I think we are doing the same thing with only a slight difference in the
implementation. For mcp251x the driver data is fix with the chip type
and there is not values set by the board. This let define the
driver_data inside the driver.

In my case I let that the platform data can be set, when CONFIG_OF=n, by
the board as it was common in the past, because I have some values that
depend on the board (number of channels, checksum enabled,..).

> For DT approach(CONFIG_OF = y) we have to define of_device_ids
> and update .driver.of_match_table with this ids.

Agree - exacttly the same is done in this driver.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================