From: Jincheng Miao <jmiao@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <rth@twiddle.net>
Cc: Riku Voipio <riku.voipio@iki.fi>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep
Date: Fri, 25 Jul 2014 16:05:34 +0800 [thread overview]
Message-ID: <53D20FCE.705@redhat.com> (raw)
In-Reply-To: <CAFEAcA_55J=-028SfzQeSS3wa2kgXnb-ToSQzgBO2dDnMYXtDw@mail.gmail.com>
On 07/25/2014 03:45 PM, Peter Maydell wrote:
> On 25 July 2014 08:41, Richard Henderson <rth@twiddle.net> wrote:
>> On 07/24/2014 09:37 PM, Peter Maydell wrote:
>>> Huh? We already don't emit goto_tb if single-stepping, surely?
>>> (Well, I guess some of the backends might well be broken, but
>>> in that case they probably don't get the other bits of singlestep
>>> support right either...)
>> Indeed. I noticed this a month or so ago.
>>
>> Almost all backends check the gdb env->single_step to prevent goto_tb, but
>> forget about the tcg debugging singlestep.
> Oh, we have two flavours of singlestep? That's confusing...
IMHO, CPUState->singlestep_enabled is a cpu execute mode, for emulating
it, an exception should be raised.
But '-singlestep' from command line rules qemu how to generate TBs and
their generated codes. In this situation, a TB only contains one
instruction,
and should be unlinked.
Am I right?
> (I'm currently working on the ARMv8 architectural singlestep,
> which will make 3 for target-arm.)
>
> thanks
> -- PMM
next prev parent reply other threads:[~2014-07-25 8:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 4:37 [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep Jincheng Miao
2014-07-25 6:58 ` Richard Henderson
2014-07-25 7:37 ` Peter Maydell
2014-07-25 7:41 ` Richard Henderson
2014-07-25 7:45 ` Peter Maydell
2014-07-25 8:05 ` Jincheng Miao [this message]
2014-07-25 12:07 ` Laurent Desnogues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D20FCE.705@redhat.com \
--to=jmiao@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.