All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Tiejun" <tiejun.chen@intel.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
	Jan Beulich <JBeulich@suse.com>,
	"Tian, Kevin" <kevin.tian@intel.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [v3][PATCH 1/1] xen:vtd: missing RMRR mapping while share EPT
Date: Fri, 25 Jul 2014 16:26:58 +0800	[thread overview]
Message-ID: <53D214D2.7000703@intel.com> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E0AB3977A@SHSMSX104.ccr.corp.intel.com>

On 2014/7/25 16:24, Zhang, Yang Z wrote:
> Jan Beulich wrote on 2014-07-25:
>>>>> On 24.07.14 at 19:12, <kevin.tian@intel.com> wrote:
>>>>> From: Chen, Tiejun
>>>> Sent: Thursday, July 24, 2014 4:00 AM
>>>>
>>>> intel_iommu_map_page() does nothing if VT-d shares EPT page table.
>>>> So rmrr_identity_mapping() never create RMRR mapping but in some
>>>> cases like some GFX drivers it still need to access RMRR.
>>>
>>> this is not accurate. as long as RMRR is reported, it's always
>>> necessary to have the identity mapping there, not just needed in
>>> SOME CASES. :-)
>>
>> Actually (as also said before) I think "in some cases" is quite correct:
>> There's no guarantee that a device will actually access the region(s)
>> an RMRR may specify for it. A particular example would be the USB case
>> where iiuc these regions are needed only until legacy mode emulation gets turned off.
>
> Yes, even for Intel GFX, the RMRR is never really accessed. So we never saw any issue even without this patch.
>

Yang,

Windows GFX driver really accesses this range now. Without this patch, 
the blue screen appears.

Tiejun

  reply	other threads:[~2014-07-25  8:26 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 11:00 [v3][PATCH 1/1] xen:vtd: missing RMRR mapping while share EPT Tiejun Chen
2014-07-24 11:11 ` Tim Deegan
2014-07-24 11:25   ` Chen, Tiejun
2014-07-24 11:35     ` Tim Deegan
2014-07-24 11:51       ` Chen, Tiejun
2014-07-24 12:16         ` Jan Beulich
2014-07-25  6:48           ` Chen, Tiejun
2014-07-25  7:07             ` Jan Beulich
2014-07-25  7:53               ` Chen, Tiejun
2014-07-25  8:02                 ` Jan Beulich
2014-07-25 12:22                   ` Tim Deegan
2014-07-24 12:10       ` Jan Beulich
2014-07-25  0:56         ` Zhang, Yang Z
2014-07-25  6:58           ` Jan Beulich
2014-07-25  8:19             ` Zhang, Yang Z
2014-07-25  8:34               ` Jan Beulich
2014-07-25  6:47       ` Chen, Tiejun
2014-07-25  8:07         ` Jan Beulich
2014-07-25  8:45           ` Chen, Tiejun
2014-07-25  9:14             ` Jan Beulich
2014-07-24 17:12 ` Tian, Kevin
2014-07-25  8:15   ` Jan Beulich
2014-07-25  8:24     ` Zhang, Yang Z
2014-07-25  8:26       ` Chen, Tiejun [this message]
2014-07-25  8:28         ` Zhang, Yang Z
2014-07-25  8:30           ` Chen, Tiejun
2014-07-25  8:36       ` Jan Beulich
2014-07-25  8:43         ` Chen, Tiejun
2014-07-25 12:53     ` Tian, Kevin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D214D2.7000703@intel.com \
    --to=tiejun.chen@intel.com \
    --cc=JBeulich@suse.com \
    --cc=kevin.tian@intel.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.