All of lore.kernel.org
 help / color / mirror / Atom feed
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 07/11] Documentation: devicetree: Fix Xilinx VDMA specification
Date: Fri, 25 Jul 2014 10:46:59 +0200	[thread overview]
Message-ID: <53D21983.8060901@suse.de> (raw)
In-Reply-To: <53D20C19.5000306@monstr.eu>

Hi Michal,

Am 25.07.2014 09:49, schrieb Michal Simek:
> On 07/25/2014 01:00 AM, Andreas F?rber wrote:
>> The specification requires xlnx,data-width, but example and driver use
>> xlnx,datawidth. Change the specification to match the implementation.
>>
>> Signed-off-by: Andreas F?rber <afaerber@suse.de>
>> ---
>>  v2: New
>>  
>>  Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>> index 1405ed0..e4c4d47 100644
>> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>> @@ -25,7 +25,7 @@ Required child node properties:
>>  - compatible: It should be either "xlnx,axi-vdma-mm2s-channel" or
>>  	"xlnx,axi-vdma-s2mm-channel".
>>  - interrupts: Should contain per channel VDMA interrupts.
>> -- xlnx,data-width: Should contain the stream data width, take values
>> +- xlnx,datawidth: Should contain the stream data width, take values
>>  	{32,64...1024}.

BTW I just notice that this values specification is ambiguous as to
whether 96 is a valid value or only powers of 2 like 128. Maybe you want
to clarify that in a follow-up patch?

Cheers,
Andreas

>>  
>>  Optional child node properties:
>>
> 
> Can you please take this patch through your tree?
> 
> Reviewed-by: Michal Simek <michal.simek@xilinx.com>
> 
> Thanks,
> Michal

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140725/ece09d6f/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>
To: monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org
Cc: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Michal Simek
	<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	Andreas Olofsson
	<andreas-hhg9azYwhpdWk0Htik3J/w@public.gmane.org>,
	Matteo Vit
	<matteo.vit-WGsyu9ztxDWovDFt+AQlJdBPR1lH4CV8@public.gmane.org>,
	Sean Rickerd <srickerd-IBi9RG/b67k@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Srikanth T <sthokal-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2 07/11] Documentation: devicetree: Fix Xilinx VDMA specification
Date: Fri, 25 Jul 2014 10:46:59 +0200	[thread overview]
Message-ID: <53D21983.8060901@suse.de> (raw)
In-Reply-To: <53D20C19.5000306-pSz03upnqPeHXe+LvDLADg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1775 bytes --]

Hi Michal,

Am 25.07.2014 09:49, schrieb Michal Simek:
> On 07/25/2014 01:00 AM, Andreas Färber wrote:
>> The specification requires xlnx,data-width, but example and driver use
>> xlnx,datawidth. Change the specification to match the implementation.
>>
>> Signed-off-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org>
>> ---
>>  v2: New
>>  
>>  Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>> index 1405ed0..e4c4d47 100644
>> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>> @@ -25,7 +25,7 @@ Required child node properties:
>>  - compatible: It should be either "xlnx,axi-vdma-mm2s-channel" or
>>  	"xlnx,axi-vdma-s2mm-channel".
>>  - interrupts: Should contain per channel VDMA interrupts.
>> -- xlnx,data-width: Should contain the stream data width, take values
>> +- xlnx,datawidth: Should contain the stream data width, take values
>>  	{32,64...1024}.

BTW I just notice that this values specification is ambiguous as to
whether 96 is a valid value or only powers of 2 like 128. Maybe you want
to clarify that in a follow-up patch?

Cheers,
Andreas

>>  
>>  Optional child node properties:
>>
> 
> Can you please take this patch through your tree?
> 
> Reviewed-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> 
> Thanks,
> Michal

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: monstr@monstr.eu
Cc: Vinod Koul <vinod.koul@intel.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Andreas Olofsson <andreas@adapteva.com>,
	Matteo Vit <matteo.vit@starwaredesign.com>,
	Sean Rickerd <srickerd@suse.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Srikanth T <sthokal@xilinx.com>
Subject: Re: [PATCH v2 07/11] Documentation: devicetree: Fix Xilinx VDMA specification
Date: Fri, 25 Jul 2014 10:46:59 +0200	[thread overview]
Message-ID: <53D21983.8060901@suse.de> (raw)
In-Reply-To: <53D20C19.5000306@monstr.eu>

[-- Attachment #1: Type: text/plain, Size: 1725 bytes --]

Hi Michal,

Am 25.07.2014 09:49, schrieb Michal Simek:
> On 07/25/2014 01:00 AM, Andreas Färber wrote:
>> The specification requires xlnx,data-width, but example and driver use
>> xlnx,datawidth. Change the specification to match the implementation.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>>  v2: New
>>  
>>  Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>> index 1405ed0..e4c4d47 100644
>> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>> @@ -25,7 +25,7 @@ Required child node properties:
>>  - compatible: It should be either "xlnx,axi-vdma-mm2s-channel" or
>>  	"xlnx,axi-vdma-s2mm-channel".
>>  - interrupts: Should contain per channel VDMA interrupts.
>> -- xlnx,data-width: Should contain the stream data width, take values
>> +- xlnx,datawidth: Should contain the stream data width, take values
>>  	{32,64...1024}.

BTW I just notice that this values specification is ambiguous as to
whether 96 is a valid value or only powers of 2 like 128. Maybe you want
to clarify that in a follow-up patch?

Cheers,
Andreas

>>  
>>  Optional child node properties:
>>
> 
> Can you please take this patch through your tree?
> 
> Reviewed-by: Michal Simek <michal.simek@xilinx.com>
> 
> Thanks,
> Michal

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-07-25  8:46 UTC|newest]

Thread overview: 167+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 23:00 [PATCH v2 00/11] ARM: dts: zynq: Prepare Parallella Andreas Färber
2014-07-24 23:00 ` Andreas Färber
2014-07-24 23:00 ` Andreas Färber
2014-07-24 23:00 ` [PATCH v2 01/11] Documentation: devicetree: Adapteva vendor prefix Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-25  8:01   ` Michal Simek
2014-07-25  8:01     ` Michal Simek
2014-07-25  8:01     ` Michal Simek
2014-07-24 23:00 ` [PATCH v2 02/11] Documentation: devicetree: Adapteva boards Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-25  8:01   ` Michal Simek
2014-07-25  8:01     ` Michal Simek
2014-07-25  8:01     ` Michal Simek
2014-07-24 23:00 ` [PATCH v2 03/11] ARM: dts: zynq: Add Parallella device tree Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-25  8:02   ` Michal Simek
2014-07-25  8:02     ` Michal Simek
2014-07-24 23:00 ` [PATCH v2 04/11] ARM: dts: zynq: Update deprecated xuartps clock names Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-24 23:09   ` Sören Brinkmann
2014-07-24 23:09     ` Sören Brinkmann
2014-07-24 23:09     ` Sören Brinkmann
2014-07-24 23:13     ` Andreas Färber
2014-07-24 23:13       ` Andreas Färber
2014-07-24 23:24       ` Sören Brinkmann
2014-07-24 23:24         ` Sören Brinkmann
2014-07-24 23:24         ` Sören Brinkmann
2014-07-25  7:38         ` Michal Simek
2014-07-25  7:38           ` Michal Simek
2014-07-24 23:00 ` [PATCH v2 05/11] ARM: dts: zynq: Add QSPI for Parallella Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-24 23:18   ` Sören Brinkmann
2014-07-24 23:18     ` Sören Brinkmann
2014-07-24 23:18     ` Sören Brinkmann
2014-07-25  7:59     ` Michal Simek
2014-07-25  7:59       ` Michal Simek
2014-07-25  7:59       ` Michal Simek
2014-07-25  8:42       ` Andreas Färber
2014-07-25  8:42         ` Andreas Färber
2014-07-25  9:38         ` Michal Simek
2014-07-25  9:38           ` Michal Simek
2014-07-25  9:38           ` Michal Simek
2014-07-25 11:12           ` [PATCH v3] ARM: dts: zynq: Add SPI Andreas Färber
2014-07-25 11:12             ` Andreas Färber
2014-07-25 11:12             ` Andreas Färber
2014-07-25 14:42             ` Sören Brinkmann
2014-07-25 14:42               ` Sören Brinkmann
2014-07-25 14:42               ` Sören Brinkmann
     [not found]             ` <20140725144223.GB16049@xsjandreislx>
2014-07-28  9:11               ` Michal Simek
2014-07-28  9:11                 ` Michal Simek
2014-07-28  9:11                 ` Michal Simek
     [not found]         ` <53D2258B.9000609@xilinx.com>
2014-07-25 10:31           ` [PATCH v2 05/11] ARM: dts: zynq: Add QSPI for Parallella Harini Katakam
2014-07-25 10:31             ` Harini Katakam
2014-07-25 10:31             ` Harini Katakam
2014-07-25 10:43             ` Andreas Färber
2014-07-25 10:43               ` Andreas Färber
2014-07-25 10:43               ` Andreas Färber
2014-07-25 10:47           ` Harini Katakam
2014-07-25 10:47             ` Harini Katakam
2014-07-25 10:47             ` Harini Katakam
2014-07-24 23:00 ` [PATCH v2 06/11] ARM: dts: zynq: Add DMAC " Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-24 23:28   ` Sören Brinkmann
2014-07-24 23:28     ` Sören Brinkmann
2014-07-24 23:28     ` Sören Brinkmann
2014-07-25  8:02     ` Michal Simek
2014-07-25  8:02       ` Michal Simek
2014-07-25  8:02       ` Michal Simek
2014-07-25  8:24       ` Andreas Färber
2014-07-25  8:24         ` Andreas Färber
2014-07-25  8:24         ` Andreas Färber
2014-07-25  8:36         ` Michal Simek
2014-07-25  8:36           ` Michal Simek
2014-07-25  8:36           ` Michal Simek
2014-07-25 14:43         ` Sören Brinkmann
2014-07-25 14:43           ` Sören Brinkmann
2014-07-25 14:43           ` Sören Brinkmann
2014-07-24 23:00 ` [PATCH v2 07/11] Documentation: devicetree: Fix Xilinx VDMA specification Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-25  7:49   ` Michal Simek
2014-07-25  7:49     ` Michal Simek
2014-07-25  7:49     ` Michal Simek
2014-07-25  8:46     ` Andreas Färber [this message]
2014-07-25  8:46       ` Andreas Färber
2014-07-25  8:46       ` Andreas Färber
2014-07-25  9:40       ` Michal Simek
2014-07-25  9:40         ` Michal Simek
2014-07-25  9:40         ` Michal Simek
     [not found]       ` <53D225F2.4070504@xilinx.com>
2014-07-25 12:51         ` Srikanth Thokala
2014-07-25 12:51           ` Srikanth Thokala
2014-07-25 12:51           ` Srikanth Thokala
2014-07-24 23:00 ` [PATCH v2 08/11] ARM: dts: zynq: Add VDMA to Parallella Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-24 23:22   ` Sören Brinkmann
2014-07-24 23:22     ` Sören Brinkmann
2014-07-24 23:22     ` Sören Brinkmann
2014-07-25  9:47     ` Andreas Färber
2014-07-25  9:47       ` Andreas Färber
2014-07-25  9:47       ` Andreas Färber
2014-07-25 14:49       ` Sören Brinkmann
2014-07-25 14:49         ` Sören Brinkmann
2014-07-25 14:49         ` Sören Brinkmann
2014-07-24 23:00 ` [PATCH v2 09/11] Documentation: devicetree: Fix ADI AXI SPDIF specification Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-25  7:42   ` Lars-Peter Clausen
2014-07-25  7:42     ` Lars-Peter Clausen
2014-07-25  7:42     ` Lars-Peter Clausen
2014-07-25  8:08     ` Michal Simek
2014-07-25  8:08       ` Michal Simek
2014-07-25 10:18       ` Mark Brown
2014-07-25 10:18         ` Mark Brown
2014-07-25 10:18         ` Mark Brown
2014-07-25 10:32         ` Andreas Färber
2014-07-25 10:32           ` Andreas Färber
2014-07-25 10:39           ` Mark Brown
2014-07-25 10:39             ` Mark Brown
2014-07-25 10:39             ` Mark Brown
2014-07-28 11:43             ` Andreas Färber
2014-07-28 11:43               ` Andreas Färber
2014-07-28 12:20               ` Mark Brown
2014-07-28 12:20                 ` Mark Brown
2014-07-28 12:28                 ` Andreas Färber
2014-07-28 12:28                   ` Andreas Färber
2014-07-28 13:44                   ` Mark Brown
2014-07-28 13:44                     ` Mark Brown
2014-07-28 13:44                     ` Mark Brown
2014-07-28 15:39                     ` Andreas Färber
2014-07-28 15:39                       ` Andreas Färber
2014-07-28 15:39                       ` Andreas Färber
2014-07-28 21:28                       ` Mark Brown
2014-07-28 21:28                         ` Mark Brown
2014-07-24 23:00 ` [PATCH v2 10/11] ARM: dts: zynq: Add SPDIF for Parallella Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-24 23:00 ` [PATCH v2 11/11] ARM: dts: zynq: Add AXI clkgen " Andreas Färber
2014-07-24 23:00   ` Andreas Färber
2014-07-25  3:49 ` [PATCH v2 00/11] ARM: dts: zynq: Prepare Parallella Punnaiah Choudary Kalluri
2014-07-25  3:49   ` Punnaiah Choudary Kalluri
2014-07-25  3:49   ` Punnaiah Choudary Kalluri
2014-07-25 10:04   ` Andreas Färber
2014-07-25 10:04     ` Andreas Färber
2014-07-25 10:04     ` Andreas Färber
2014-07-28 16:17 ` Andreas Färber
2014-07-28 16:17   ` Andreas Färber
2014-07-28 16:17   ` Andreas Färber
2014-07-28 16:39   ` Lars-Peter Clausen
2014-07-28 16:39     ` Lars-Peter Clausen
2014-10-18  4:28 ` Olof Johansson
2014-10-18  4:28   ` Olof Johansson
2014-10-19 15:57   ` Soren Brinkmann
2014-10-19 15:57     ` Soren Brinkmann
2014-10-21 20:52   ` Andreas Färber
2014-10-21 20:52     ` Andreas Färber
2014-10-21 21:00     ` Sören Brinkmann
2014-10-21 21:00       ` Sören Brinkmann
2014-10-21 21:00       ` Sören Brinkmann
2014-10-21 21:01     ` Olof Johansson
2014-10-21 21:01       ` Olof Johansson
2014-10-21 21:07       ` Andreas Färber
2014-10-21 21:07         ` Andreas Färber
2014-10-21 21:18         ` Olof Johansson
2014-10-21 21:18           ` Olof Johansson
2014-10-22 13:22           ` Michal Simek
2014-10-22 13:22             ` Michal Simek
2014-10-22 13:22             ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D21983.8060901@suse.de \
    --to=afaerber@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.