From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Wolfram Sang <wsa@sang-engineering.com>,
Mugunthan V N <mugunthanvnm@ti.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Pavel Machek <pavel@denx.de>, Thor Thayer <tthayer@altera.com>,
Prabhakar Lad <prabhakar.csengg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Chen Gang <gang.chen@asianux.com>,
George Cherian <george.cherian@ti.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [can-next PATCH 1/1] net: can: c_can_platform: Use devm_ioremap instead of devm_ioremap_resource.
Date: Fri, 25 Jul 2014 15:06:03 +0200 [thread overview]
Message-ID: <53D2563B.1090703@pengutronix.de> (raw)
In-Reply-To: <4a97162dedd6ab064e83c52757f2ce42@mail.zeus03.de>
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]
On 07/25/2014 12:49 PM, Wolfram Sang wrote:
> Am 25-07-2014 08:19, schrieb Mugunthan V N:
>> From: George Cherian <george.cherian@ti.com>
>>
>> The raminit register is shared register for both can0 and can1.
>> Using devm_ioremap_resource fails the mapping for can1 interface
>> leading to a non functional can interface.
>>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>
> The patch is a hack, or? It simply works because we drop all sanity
> checking on the resource.
Well, thinking about it, yes, a bit.
> I am on holiday and can't really check, yet I believe the AM335x has
> devicetree support for accessing single bits in SYSCONF. This is what
> needs to be applied here, too, AFAICT.
I cannot find any generic driver for the sysconf, USB and Ethernet have
an extra driver for their shared register space. I think the d_can can
access the raminit register via a syscon driver.
Enjoy your holiday :)
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
prev parent reply other threads:[~2014-07-25 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 6:19 [can-next PATCH 1/1] net: can: c_can_platform: Use devm_ioremap instead of devm_ioremap_resource Mugunthan V N
2014-07-25 6:19 ` Mugunthan V N
2014-07-25 7:38 ` Marc Kleine-Budde
2014-07-25 10:49 ` Wolfram Sang
2014-07-25 13:06 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D2563B.1090703@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=gang.chen@asianux.com \
--cc=george.cherian@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@denx.de \
--cc=prabhakar.csengg@gmail.com \
--cc=tglx@linutronix.de \
--cc=tthayer@altera.com \
--cc=wg@grandegger.com \
--cc=wsa@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.