From: drEagle <drEagle@DOUKKI.NET>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/1] ARM: kirkwood: add mvsdio driver
Date: Fri, 25 Jul 2014 15:34:18 +0200 [thread overview]
Message-ID: <53D25CDA.1050908@DOUKKI.NET> (raw)
In-Reply-To: <53D2041E.7010906@gmail.com>
Hi Stefan,
On 25/07/2014 09:15, Stefan Roese wrote:
> Hi Gerald,
> Thanks. But still some more comments below.
Thanks for the review.
Just sent a new version of the patch.
> I still don't see why this function is needed for the MMC driver. It seems to only be used from a debug() output. I suggest to remove it from this patch to not touch the general kirkwood stuff.
>
> Also this MMC driver should be able to support multiple Marvells SoC's, right? So calling some "kirkwood" functions doesn't seem to be generic.
Agree, cleaned as requested.
> Again, please use the SPDX license identifier as done in all U-Boot sources now. This is mandatory!
Oops...
> BTW: You seem to be adding a new Kirkwood SoC version with this MMC patch. This really is not MMC related and should be split into a separate patch.
Will do this.
Enjoy,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 538 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140725/d7027389/attachment.pgp>
next prev parent reply other threads:[~2014-07-25 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 19:07 [U-Boot] [PATCH v4 1/1] ARM: kirkwood: add mvsdio driver Gerald Kerma
2014-07-25 7:15 ` Stefan Roese
2014-07-25 13:34 ` drEagle [this message]
2014-07-25 14:46 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D25CDA.1050908@DOUKKI.NET \
--to=dreagle@doukki.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.