From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2] docs: make .txt files over-writable when building from r/o sources Date: Fri, 25 Jul 2014 16:24:56 +0100 Message-ID: <53D276C8.50303@citrix.com> References: <53B6D9CF0200007800020CB9@mail.emea.novell.com> <53B6BE68.3000408@citrix.com> <53D28C43020000780002613A@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5171369551929050037==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XAhMk-0003yX-HL for xen-devel@lists.xenproject.org; Fri, 25 Jul 2014 15:25:02 +0000 In-Reply-To: <53D28C43020000780002613A@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org --===============5171369551929050037== Content-Type: multipart/alternative; boundary="------------030302000903080206000301" --------------030302000903080206000301 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 25/07/14 15:56, Jan Beulich wrote: > Otherwise an incremental build will fail to overwrite the destination > files. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper > --- > v2: Use $(INSTALL_DATA) instead of cp+chmod. > > --- a/docs/Makefile > +++ b/docs/Makefile > @@ -124,7 +124,7 @@ endif > > html/%.txt: %.txt > $(INSTALL_DIR) $(@D) > - cp $< $@ > + $(INSTALL_DATA) $< $@ > > html/man/%.1.html: man/%.pod.1 Makefile > $(INSTALL_DIR) $(@D) > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --------------030302000903080206000301 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit
On 25/07/14 15:56, Jan Beulich wrote:
Otherwise an incremental build will fail to overwrite the destination
files.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

---
v2: Use $(INSTALL_DATA) instead of cp+chmod.

--- a/docs/Makefile
+++ b/docs/Makefile
@@ -124,7 +124,7 @@ endif
 
 html/%.txt: %.txt
 	$(INSTALL_DIR) $(@D)
-	cp $< $@
+	$(INSTALL_DATA) $< $@
 
 html/man/%.1.html: man/%.pod.1 Makefile
 	$(INSTALL_DIR) $(@D)






_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--------------030302000903080206000301-- --===============5171369551929050037== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5171369551929050037==--