From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [PATCH v2 1/4] ARM: dts: exynos5250: max77686 is Snow only Date: Fri, 25 Jul 2014 17:30:12 +0200 Message-ID: <53D27804.40601@suse.de> References: <1405704009-8430-1-git-send-email-afaerber@suse.de> <1405704009-8430-2-git-send-email-afaerber@suse.de> <08fe01cfa7c9$341cc700$9c565500$@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Doug Anderson Cc: Mark Rutland , "OPEN FIRMWARE AND..." , linux-samsung-soc , Vincent Palatin , Pawel Moll , Ian Campbell , LKML , Stephan van Schaik , Russell King , Rob Herring , Ben Dooks , Kumar Gala , Kukjin Kim , Javier Martinez Canillas , "ARM/SAMSUNG ARM A..." List-Id: linux-samsung-soc@vger.kernel.org SGkgRG91ZywKCkFtIDI1LjA3LjIwMTQgMTc6MTMsIHNjaHJpZWIgRG91ZyBBbmRlcnNvbjoKPiBP biBGcmksIEp1bCAyNSwgMjAxNCBhdCA4OjA4IEFNLCBEb3VnIEFuZGVyc29uIDxkaWFuZGVyc0Bj aHJvbWl1bS5vcmc+IHdyb3RlOgo+PiBPbiBUaHUsIEp1bCAyNCwgMjAxNCBhdCAxMDoyOCBQTSwg S3VramluIEtpbSA8a2dlbmUua2ltQHNhbXN1bmcuY29tPiB3cm90ZToKPj4+IEFuZHJlYXMgRsOk cmJlciB3cm90ZToKPj4+Pgo+Pj4+IE1vdmUgaXQgZnJvbSBleHlub3M1MjUwLWNyb3MtY29tbW9u LmR0c2kgdG8gZXh5bm9zNTI1MC1zbm93LmR0cy4KPj4+PiBTcHJpbmcgZG9lcyBub3QgbmVlZCBp dCwgaXQgdXNlcyBhbiBzNW04NzY3IGluc3RlYWQuCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBB bmRyZWFzIEbDpHJiZXIgPGFmYWVyYmVyQHN1c2UuZGU+Cj4+Pj4gLS0tCj4+Pgo+Pj4gRG91Zywg Y2FuIHlvdSBoYXZlIGEgbG9vayB0aGlzIHNlcmllcyBmb3IgZXh5bm9zNTI1MC1jaHJvbWVib29r Pwo+Pj4gSSdtIG5vdCBzdXJlIGV4eW5vczUyNTAtY3Jvcy1jb21tb24gaXMgc3RpbGwgdXNlZnVs IGZvciBleHlub3M1MjUwLXNwcmluZy4uLgo+Pgo+PiBSaWdodC4gIFRoZSBjdXJyZW50IHN1Z2dl c3Rpb24gaXMgdG8gcmV3b3JrIHRvIGp1c3QgZHVwbGljYXRlIHRoaW5ncwo+PiBhbmQgZG9uJ3Qg dXNlIGV4eW5vczUyNTAtY3Jvcy1jb21tb24uCj4gCj4gT2gsIGl0IGFjdHVhbGx5IGxvb2tzIGxp a2UgeW91ciBwYXRjaCBzZXJpZXMgZW5kcyB1cCB0aGVyZSwgYnV0IHRoZQo+IGZpcnN0IHBhdGNo IGNvbmZ1c2VkIG1lLgoKTlAsIGd1ZXNzIHlvdSBqdXN0IHN0YXJ0ZWQgcmVhZGluZyBpbiB0aGUg bWlkZGxlLiA7KQoKPiAgV2h5IG1vdmUganVzdCB0aGUgbWF4aW0gUE1JQyBmaXJzdD8KClJldmll dyBvZiB0aGUgbW92ZW1lbnRzIHN1cmVseSBpcyBlYXNpZXIgdGhpcyB3YXksIGFuZCBpdCBkaWQg bm90IHlldApzZWVtIGEgZG9uZSBkZWFsIHRoYXQgd2Ugd291bGQgZHJvcCAtY3Jvcy1jb21tb24u IFRoZSBtZXJnZSBwYXRjaCBuaWNlbHkKc2hvd3Mgd2hpY2ggY29tbW9uIHBhcnRzIG5lZWQgdG8g YmUgY29waWVkIGludG8gc3ByaW5nLgoKPiAgTW92ZQo+IGV2ZXJ5dGhpbmcgYXQgb25jZSBhbmQg YmUgZG9uZSB3aXRoIHRoZSBjb21tb24gZmlsZSwgdGhlbiBkbwo+IGNsZWFudXAuLi4KCklmIGV2 ZXJ5b25lIGFncmVlcyB0aGF0IHdlIHdhbnQgdG8gcHJvY2VlZCB0aGF0IHdheSwgd2UgY2FuIGVh c2lseQpzcXVhc2ggcGF0Y2hlcyAxKzIuIFNlcGFyYXRpbmcgaXMgYWx3YXlzIGhhcmRlci4KCkNo ZWVycywKQW5kcmVhcwoKLS0gClNVU0UgTElOVVggUHJvZHVjdHMgR21iSCwgTWF4ZmVsZHN0ci4g NSwgOTA0MDkgTsO8cm5iZXJnLCBHZXJtYW55CkdGOiBKZWZmIEhhd24sIEplbm5pZmVyIEd1aWxk LCBGZWxpeCBJbWVuZMO2cmZmZXI7IEhSQiAxNjc0NiBBRyBOw7xybmJlcmcKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: afaerber@suse.de (=?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?=) Date: Fri, 25 Jul 2014 17:30:12 +0200 Subject: [PATCH v2 1/4] ARM: dts: exynos5250: max77686 is Snow only In-Reply-To: References: <1405704009-8430-1-git-send-email-afaerber@suse.de> <1405704009-8430-2-git-send-email-afaerber@suse.de> <08fe01cfa7c9$341cc700$9c565500$@samsung.com> Message-ID: <53D27804.40601@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Doug, Am 25.07.2014 17:13, schrieb Doug Anderson: > On Fri, Jul 25, 2014 at 8:08 AM, Doug Anderson wrote: >> On Thu, Jul 24, 2014 at 10:28 PM, Kukjin Kim wrote: >>> Andreas F?rber wrote: >>>> >>>> Move it from exynos5250-cros-common.dtsi to exynos5250-snow.dts. >>>> Spring does not need it, it uses an s5m8767 instead. >>>> >>>> Signed-off-by: Andreas F?rber >>>> --- >>> >>> Doug, can you have a look this series for exynos5250-chromebook? >>> I'm not sure exynos5250-cros-common is still useful for exynos5250-spring... >> >> Right. The current suggestion is to rework to just duplicate things >> and don't use exynos5250-cros-common. > > Oh, it actually looks like your patch series ends up there, but the > first patch confused me. NP, guess you just started reading in the middle. ;) > Why move just the maxim PMIC first? Review of the movements surely is easier this way, and it did not yet seem a done deal that we would drop -cros-common. The merge patch nicely shows which common parts need to be copied into spring. > Move > everything at once and be done with the common file, then do > cleanup... If everyone agrees that we want to proceed that way, we can easily squash patches 1+2. Separating is always harder. Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760788AbaGYPaj (ORCPT ); Fri, 25 Jul 2014 11:30:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43500 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753817AbaGYPaR (ORCPT ); Fri, 25 Jul 2014 11:30:17 -0400 Message-ID: <53D27804.40601@suse.de> Date: Fri, 25 Jul 2014 17:30:12 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Doug Anderson CC: Kukjin Kim , linux-samsung-soc , Stephan van Schaik , Vincent Palatin , Ben Dooks , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , "ARM/SAMSUNG ARM A..." , "OPEN FIRMWARE AND..." , LKML , Javier Martinez Canillas Subject: Re: [PATCH v2 1/4] ARM: dts: exynos5250: max77686 is Snow only References: <1405704009-8430-1-git-send-email-afaerber@suse.de> <1405704009-8430-2-git-send-email-afaerber@suse.de> <08fe01cfa7c9$341cc700$9c565500$@samsung.com> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug, Am 25.07.2014 17:13, schrieb Doug Anderson: > On Fri, Jul 25, 2014 at 8:08 AM, Doug Anderson wrote: >> On Thu, Jul 24, 2014 at 10:28 PM, Kukjin Kim wrote: >>> Andreas Färber wrote: >>>> >>>> Move it from exynos5250-cros-common.dtsi to exynos5250-snow.dts. >>>> Spring does not need it, it uses an s5m8767 instead. >>>> >>>> Signed-off-by: Andreas Färber >>>> --- >>> >>> Doug, can you have a look this series for exynos5250-chromebook? >>> I'm not sure exynos5250-cros-common is still useful for exynos5250-spring... >> >> Right. The current suggestion is to rework to just duplicate things >> and don't use exynos5250-cros-common. > > Oh, it actually looks like your patch series ends up there, but the > first patch confused me. NP, guess you just started reading in the middle. ;) > Why move just the maxim PMIC first? Review of the movements surely is easier this way, and it did not yet seem a done deal that we would drop -cros-common. The merge patch nicely shows which common parts need to be copied into spring. > Move > everything at once and be done with the common file, then do > cleanup... If everyone agrees that we want to proceed that way, we can easily squash patches 1+2. Separating is always harder. Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg