From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
Subject: Re: [PATCH 2/2] xen: arm: update arm32 assembly primitives to Linux v3.16-rc6
Date: Fri, 25 Jul 2014 16:48:59 +0100 [thread overview]
Message-ID: <53D27C6B.6070907@linaro.org> (raw)
In-Reply-To: <1406303283.24842.41.camel@kazak.uk.xensource.com>
On 07/25/2014 04:48 PM, Ian Campbell wrote:
> On Fri, 2014-07-25 at 16:42 +0100, Julien Grall wrote:
>> Hi Ian,
>>
>> On 07/25/2014 04:22 PM, Ian Campbell wrote:
>>> bitops, cmpxchg, atomics: Import:
>>> c32ffce ARM: 7984/1: prefetch: add prefetchw invocations for barriered atomics
>>
>> Compare to Linux we don't have specific prefetch* helpers. We directly
>> use the compiler builtin ones. Shouldn't we import the ARM specific
>> helpers to gain in performance?
>
> My binaries are full of pld instructions where I think I would expect
> them, so it seems like the compiler builtin ones are sufficient.
>
> I suspect the Linux define is there to cope with older compilers or
> something.
If so:
Acked-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-07-25 15:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 15:22 [PATCH 1/2] xen: arm: update arm64 assembly primitives to Linux v3.16-rc6 Ian Campbell
2014-07-25 15:22 ` [PATCH 2/2] xen: arm: update arm32 " Ian Campbell
2014-07-25 15:42 ` Julien Grall
2014-07-25 15:48 ` Ian Campbell
2014-07-25 15:48 ` Julien Grall [this message]
2014-07-25 16:03 ` Ian Campbell
2014-07-25 16:13 ` Ian Campbell
2014-07-25 16:20 ` Julien Grall
2014-07-25 16:17 ` Julien Grall
2014-07-25 16:23 ` Ian Campbell
2014-07-25 15:36 ` [PATCH 1/2] xen: arm: update arm64 " Julien Grall
2014-08-04 16:16 ` Ian Campbell
2014-07-25 15:43 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D27C6B.6070907@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.