All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Julian Squires <julian@cipht.net>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: wacom_serial4 - prepare for wacom USB moving to HID
Date: Fri, 25 Jul 2014 21:06:28 +0200	[thread overview]
Message-ID: <53D2AAB4.1090109@redhat.com> (raw)
In-Reply-To: <20140724203108.GA9191@core.coreip.homeip.net>

Hi,

On 07/24/2014 10:31 PM, Dmitry Torokhov wrote:
> wacom_wac.h will be moving to drivers/hid. Since we only need 3 definitions
> from it let's simply copy them over.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Ack, but you will want to drop the #include of wacom_wac.h yoo.

Regards,

Hans

> ---
>  drivers/input/tablet/wacom_serial4.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/input/tablet/wacom_serial4.c b/drivers/input/tablet/wacom_serial4.c
> index d3d251e..deef50e 100644
> --- a/drivers/input/tablet/wacom_serial4.c
> +++ b/drivers/input/tablet/wacom_serial4.c
> @@ -149,6 +149,11 @@ MODULE_LICENSE("GPL");
>  #define F_HAS_STYLUS2		0x02
>  #define F_HAS_SCROLLWHEEL	0x04
>  
> +/* device IDs */
> +#define STYLUS_DEVICE_ID	0x02
> +#define CURSOR_DEVICE_ID	0x06
> +#define ERASER_DEVICE_ID	0x0A
> +
>  enum { STYLUS = 1, ERASER, CURSOR };
>  
>  static const struct {
> 

  reply	other threads:[~2014-07-25 19:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 20:31 [PATCH] Input: wacom_serial4 - prepare for wacom USB moving to HID Dmitry Torokhov
2014-07-25 19:06 ` Hans de Goede [this message]
2014-07-25 19:42   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D2AAB4.1090109@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=julian@cipht.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.