From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cubieboard2: Enable AXP209 power controller
Date: Sun, 27 Jul 2014 12:04:10 +0200 [thread overview]
Message-ID: <53D4CE9A.4080705@redhat.com> (raw)
In-Reply-To: <1406449897.3844.6.camel@hastur.hellion.org.uk>
Hi,
On 07/27/2014 10:31 AM, Ian Campbell wrote:
> On Sat, 2014-07-26 at 15:23 +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 07/24/2014 10:19 AM, Ian Campbell wrote:
>>> For some reason even the original sunxi tree was missing this.
>>
>> The original tree is not missing it, in the original tree the logic is backwards,
>> all board get AXP209 unless NO_AXP or AXP152 are defined.
>
> Ah, I missed that tricky bit of logic.
>
>> I decided to not carry this "magic" forward to the upstream code,
>
> Yes, that makes absolute sense (and I now vague recall you telling me
> this before).
>
>> which means
>> that any board which does not have NO_AXP or AXP152 upstream needs AXP209
>>
>>>
>>> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
>>
>> Acked-by: Hans de Goede <hdegoede@redhat.com>
>
> Thanks.
>
> FYI I've started collecting things into next to be swept into master and
> PR-d once the existing PR goes through.
Right, I've been using that tree to base my current work to add support
for more boards on:
https://github.com/jwrdegoede/u-boot-sunxi/commits/next
Regards,
Hans
next prev parent reply other threads:[~2014-07-27 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 8:19 [U-Boot] [PATCH] cubieboard2: Enable AXP209 power controller Ian Campbell
2014-07-26 13:23 ` Hans de Goede
2014-07-27 8:31 ` Ian Campbell
2014-07-27 10:04 ` Hans de Goede [this message]
2014-07-27 20:52 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D4CE9A.4080705@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.