From: Zhang Zhen <zhenzhang.zhang@huawei.com>
To: shaohui.zheng@intel.com, mgorman@suse.de, mingo@redhat.com,
Linux MM <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org
Cc: wangnan0@huawei.com, akpm@linux-foundation.org
Subject: [PATCH] memory hotplug: update the variables after memory removed
Date: Mon, 28 Jul 2014 20:32:37 +0800 [thread overview]
Message-ID: <53D642E5.2010305@huawei.com> (raw)
In-Reply-To: <1406550617-19556-1-git-send-email-zhenzhang.zhang@huawei.com>
Commit ea0854170c95245a258b386c7a9314399c949fe0 added a fuction
update_end_of_memory_vars() to update high_memory, max_pfn and
max_low_pfn.
Here modified the function(added an argument to show add or remove).
And call it in arch_remove_memory() to update these variables too.
Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
---
arch/x86/mm/init_64.c | 29 +++++++++++++++++++++--------
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index df1a992..2557091 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -673,14 +673,24 @@ void __init paging_init(void)
* After memory hotplug the variables max_pfn, max_low_pfn and high_memory need
* updating.
*/
-static void update_end_of_memory_vars(u64 start, u64 size)
+static void update_end_of_memory_vars(u64 start, u64 size, bool flag)
{
- unsigned long end_pfn = PFN_UP(start + size);
-
- if (end_pfn > max_pfn) {
- max_pfn = end_pfn;
- max_low_pfn = end_pfn;
- high_memory = (void *)__va(max_pfn * PAGE_SIZE - 1) + 1;
+ unsigned long end_pfn;
+
+ if (flag) {
+ end_pfn = PFN_UP(start + size);
+ if (end_pfn > max_pfn) {
+ max_pfn = end_pfn;
+ max_low_pfn = end_pfn;
+ high_memory = (void *)__va(max_pfn * PAGE_SIZE - 1) + 1;
+ }
+ } else {
+ end_pfn = PFN_UP(start);
+ if (end_pfn < max_pfn) {
+ max_pfn = end_pfn;
+ max_low_pfn = end_pfn;
+ high_memory = (void *)__va(max_pfn * PAGE_SIZE - 1) + 1;
+ }
}
}
@@ -702,7 +712,7 @@ int arch_add_memory(int nid, u64 start, u64 size)
WARN_ON_ONCE(ret);
/* update max_pfn, max_low_pfn and high_memory */
- update_end_of_memory_vars(start, size);
+ update_end_of_memory_vars(start, size, true);
return ret;
}
@@ -1025,6 +1035,9 @@ int __ref arch_remove_memory(u64 start, u64 size)
ret = __remove_pages(zone, start_pfn, nr_pages);
WARN_ON_ONCE(ret);
+ /* update max_pfn, max_low_pfn and high_memory */
+ update_end_of_memory_vars(start, size, false);
+
return ret;
}
#endif
--
1.8.1.2
.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Zhang Zhen <zhenzhang.zhang@huawei.com>
To: <shaohui.zheng@intel.com>, <mgorman@suse.de>, <mingo@redhat.com>,
Linux MM <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Cc: <wangnan0@huawei.com>, <akpm@linux-foundation.org>
Subject: [PATCH] memory hotplug: update the variables after memory removed
Date: Mon, 28 Jul 2014 20:32:37 +0800 [thread overview]
Message-ID: <53D642E5.2010305@huawei.com> (raw)
In-Reply-To: <1406550617-19556-1-git-send-email-zhenzhang.zhang@huawei.com>
Commit ea0854170c95245a258b386c7a9314399c949fe0 added a fuction
update_end_of_memory_vars() to update high_memory, max_pfn and
max_low_pfn.
Here modified the function(added an argument to show add or remove).
And call it in arch_remove_memory() to update these variables too.
Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>
---
arch/x86/mm/init_64.c | 29 +++++++++++++++++++++--------
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index df1a992..2557091 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -673,14 +673,24 @@ void __init paging_init(void)
* After memory hotplug the variables max_pfn, max_low_pfn and high_memory need
* updating.
*/
-static void update_end_of_memory_vars(u64 start, u64 size)
+static void update_end_of_memory_vars(u64 start, u64 size, bool flag)
{
- unsigned long end_pfn = PFN_UP(start + size);
-
- if (end_pfn > max_pfn) {
- max_pfn = end_pfn;
- max_low_pfn = end_pfn;
- high_memory = (void *)__va(max_pfn * PAGE_SIZE - 1) + 1;
+ unsigned long end_pfn;
+
+ if (flag) {
+ end_pfn = PFN_UP(start + size);
+ if (end_pfn > max_pfn) {
+ max_pfn = end_pfn;
+ max_low_pfn = end_pfn;
+ high_memory = (void *)__va(max_pfn * PAGE_SIZE - 1) + 1;
+ }
+ } else {
+ end_pfn = PFN_UP(start);
+ if (end_pfn < max_pfn) {
+ max_pfn = end_pfn;
+ max_low_pfn = end_pfn;
+ high_memory = (void *)__va(max_pfn * PAGE_SIZE - 1) + 1;
+ }
}
}
@@ -702,7 +712,7 @@ int arch_add_memory(int nid, u64 start, u64 size)
WARN_ON_ONCE(ret);
/* update max_pfn, max_low_pfn and high_memory */
- update_end_of_memory_vars(start, size);
+ update_end_of_memory_vars(start, size, true);
return ret;
}
@@ -1025,6 +1035,9 @@ int __ref arch_remove_memory(u64 start, u64 size)
ret = __remove_pages(zone, start_pfn, nr_pages);
WARN_ON_ONCE(ret);
+ /* update max_pfn, max_low_pfn and high_memory */
+ update_end_of_memory_vars(start, size, false);
+
return ret;
}
#endif
--
1.8.1.2
.
next parent reply other threads:[~2014-07-28 12:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1406550617-19556-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-07-28 12:32 ` Zhang Zhen [this message]
2014-07-28 12:32 ` [PATCH] memory hotplug: update the variables after memory removed Zhang Zhen
2014-07-28 15:12 ` Dave Hansen
2014-07-28 15:12 ` Dave Hansen
2014-07-28 23:12 ` David Rientjes
2014-07-28 23:12 ` David Rientjes
2014-07-28 23:24 ` Dave Hansen
2014-07-28 23:24 ` Dave Hansen
2014-07-29 6:55 ` Zhang Zhen
2014-07-29 6:55 ` Zhang Zhen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D642E5.2010305@huawei.com \
--to=zhenzhang.zhang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=shaohui.zheng@intel.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.