From: Martin Fuzzey <mfuzzey@parkeon.com>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 4/8] iio: mma8452: Add support for transient event debouncing
Date: Mon, 28 Jul 2014 15:41:55 +0200 [thread overview]
Message-ID: <53D65323.8030507@parkeon.com> (raw)
In-Reply-To: <alpine.DEB.2.01.1407232016350.21518@pmeerw.net>
On 23/07/14 20:20, Peter Meerwald wrote:
> +static ssize_t mma8452_set_transient_period(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf,
> + size_t len)
> +{
> + struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> + struct mma8452_data *data = iio_priv(indio_dev);
> + int i, f, us, steps, ret;
> +
> + ret = iio_str_to_fixpoint(buf, USEC_PER_SEC / 10, &i, &f);
> + if (ret)
> + return ret;
> +
> + us = i * USEC_PER_SEC + f;
> + steps = us / mma8452_transient_time_step_us[
> + mma8452_get_odr_index(data)];
> +
> + if (steps < 0 || steps > 0xFF)
> perhaps do the check for negative i earlier; use lowercase hex-values
>
Ok done for V2
next prev parent reply other threads:[~2014-07-28 13:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 17:17 [PATCH 0/8] iio: mma8452 enhancements Martin Fuzzey
2014-07-23 17:17 ` [PATCH 1/8] iio: mma8452: Initialise before activating Martin Fuzzey
2014-07-23 18:05 ` Peter Meerwald
2014-07-28 15:53 ` Martin Fuzzey
2014-07-23 17:17 ` [PATCH 2/8] iio: mma8452: Add access to registers via DebugFS Martin Fuzzey
2014-07-23 17:17 ` [PATCH 3/8] iio: mma8452: Basic support for transient events Martin Fuzzey
2014-07-23 18:12 ` Peter Meerwald
2014-07-28 13:37 ` Martin Fuzzey
2014-07-28 19:34 ` Jonathan Cameron
2014-07-23 17:17 ` [PATCH 4/8] iio: mma8452: Add support for transient event debouncing Martin Fuzzey
2014-07-23 18:20 ` Peter Meerwald
2014-07-28 13:41 ` Martin Fuzzey [this message]
2014-07-23 17:17 ` [PATCH 5/8] iio: core: add high pass filter attributes Martin Fuzzey
2014-07-23 17:17 ` [PATCH 6/8] io: mma8452: Add highpass filter configuration Martin Fuzzey
2014-07-23 17:17 ` [PATCH 7/8] iio: mma8452: add an attribute to enable the highpass filter Martin Fuzzey
2014-07-23 18:36 ` Peter Meerwald
2014-07-28 13:59 ` Martin Fuzzey
2014-07-23 17:17 ` [PATCH 8/8] iio: mma8452: Add support for interrupt driven triggers Martin Fuzzey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D65323.8030507@parkeon.com \
--to=mfuzzey@parkeon.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.