From: Don Slutz <dslutz@verizon.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Don Slutz <dslutz@verizon.com>,
xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Liu Jinsong <jinsong.liu@alibaba-inc.com>,
Christoph Egger <chegger@amazon.de>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Jan Beulich <jbeulich@suse.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH 1/3] cmdline_parse: Also pass bool_assert to OPT_CUSTOM so that parse_bool can be used correctly.
Date: Mon, 28 Jul 2014 12:18:34 -0400 [thread overview]
Message-ID: <53D677DA.1060801@terremark.com> (raw)
In-Reply-To: <53D6757E.3050708@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1306 bytes --]
On 07/28/14 12:08, Andrew Cooper wrote:
> On 28/07/14 16:59, Don Slutz wrote:
>> Based on:
>>
>> commit 2fcb51bc7a4fcb7534265d7bb155c6ddf03952b8
>> Author:kfraser@localhost.localdomain <kfraser@localhost.localdomain>
>> Date: Mon Jul 9 14:29:53 2007 +0100
>>
>> Also allow boolean cmdline params to be inverted in two other ways.
>>
>> Now, a standard boolean (e.g., watchdog) can be inverted in three
>> ways:
>> 1. no-watchdog
>> 2. watchdog=no
>> 3. watchdog=off
>>
>> Stacked inversions cancel each other: no-watchdog=no turns on the
>> watchdog.
>>
>> bool_assert is needed to do stacked inversions with parse_bool.
>>
>> Signed-off-by: Don Slutz<dslutz@verizon.com>
>
> Why do we need to care about stacked inversions?
>
> From xen-command-line.markdown:
>
> "Explicitly specifying any value other than those listed above is
> undefined, as is stacking a |no-| prefix with an explicit value."
>
The command line:
no-console_timestamps dom0_mem=3G loglvl=all guest_loglvl=all
com1=9600,8n1 console=com1 crashkernel=256M@256M no-console_timestamps=no
in 4.4 and before ends up with date style console_timestamps. In xen
4.5 you get no console_timestamps.
The simpler case of no-console_timestamps no longer works also.
-Don Slutz
> ~Andrew
[-- Attachment #1.2: Type: text/html, Size: 2468 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-07-28 16:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 15:59 [PATCH 0/3] parse_bool fixes Don Slutz
2014-07-28 15:59 ` [PATCH 1/3] cmdline_parse: Also pass bool_assert to OPT_CUSTOM so that parse_bool can be used correctly Don Slutz
2014-07-28 16:06 ` Jan Beulich
2014-07-28 17:12 ` Don Slutz
2014-07-28 19:19 ` Keir Fraser
2014-07-28 20:30 ` Don Slutz
2014-07-29 6:35 ` Jan Beulich
2014-07-29 20:05 ` Don Slutz
2014-07-28 16:08 ` Andrew Cooper
2014-07-28 16:18 ` Don Slutz [this message]
2014-07-28 16:23 ` Andrew Cooper
2014-07-28 19:07 ` Don Slutz
2014-07-28 16:39 ` Jan Beulich
2014-07-28 15:59 ` [PATCH 2/3] xen/console: Better handing of console_timestamps as a boolean_param Don Slutz
2014-07-28 15:59 ` [PATCH 3/3] Adjust parse_vpmu_param use of parse_bool Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D677DA.1060801@terremark.com \
--to=dslutz@verizon.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=chegger@amazon.de \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jinsong.liu@alibaba-inc.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.