From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH 1/3] cmdline_parse: Also pass bool_assert to
 OPT_CUSTOM so that parse_bool can be used correctly.
Date: Mon, 28 Jul 2014 13:12:40 -0400
Message-ID: <53D68488.3060204@terremark.com>
References: <1406563175-23761-1-git-send-email-dslutz@verizon.com>
	<1406563175-23761-2-git-send-email-dslutz@verizon.com>
	<53D691420200007800026CAD@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <53D691420200007800026CAD@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Don Slutz <dslutz@verizon.com>
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Liu Jinsong <jinsong.liu@alibaba-inc.com>, Christoph Egger <chegger@amazon.de>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Stefano Stabellini <stefano.stabellini@citrix.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
List-Id: xen-devel@lists.xenproject.org


On 07/28/14 12:06, Jan Beulich wrote:
>>>> On 28.07.14 at 17:59, <dslutz@verizon.com> wrote:
>> --- a/xen/arch/x86/apic.c
>> +++ b/xen/arch/x86/apic.c
>> @@ -809,20 +809,20 @@ int lapic_resume(void)
>>    * Original code written by Keir Fraser.
>>    */
>>   
>> -static void __init lapic_disable(char *str)
>> +static void __init lapic_disable(char *str, int bool_assert)
>>   {
>>       enable_local_apic = -1;
>>       setup_clear_cpu_cap(X86_FEATURE_APIC);
>>   }
>>   custom_param("nolapic", lapic_disable);
>>   
>> -static void __init lapic_enable(char *str)
>> +static void __init lapic_enable(char *str, int bool_assert)
>>   {
>>       enable_local_apic = 1;
>>   }
>>   custom_param("lapic", lapic_enable);
>>   
>> -static void __init apic_set_verbosity(char *str)
>> +static void __init apic_set_verbosity(char *str, int bool_assert)
>>   {
>>       if (strcmp("debug", str) == 0)
>>           apic_verbosity = APIC_DEBUG;
> This adding of a new parameter to all custom parameter parsers,
> with rarely any actually using it is a no-go as far as I'm concerned.
> That said, being of boolean type, this would need to be bool_t
> anyway.

I considered adding a new custom type, but when this way.  I would think 
that if a custom parameter parser is ignoring the "no-" (which they all do)
they should be reporting on it.


I.E. "no-lapic" currently means "lapic" and "no-nolapic" means "nolapic"
with out any message to that effect.

     -Don Slutz

> Jan
>