From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Andreas Faerber <afaerber@suse.de>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/4] qemu-char: add -chardev exit-on-eof option
Date: Mon, 28 Jul 2014 15:21:26 -0600 [thread overview]
Message-ID: <53D6BED6.6070709@redhat.com> (raw)
In-Reply-To: <1406294206-26679-4-git-send-email-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]
On 07/25/2014 07:16 AM, Stefan Hajnoczi wrote:
> When QEMU is executed as part of a test case or from a script, it is
> usually desirable to exit if the parent process terminates. This
> ensures that "leaked" QEMU processes do not continue consuming resources
> after their parent has died.
>
> This patch adds the -chardev exit-on-eof option causing socket and pipe
> chardevs to exit QEMU upon close. This happens when a parent process
> deliberately closes its file descriptor but also when the kernel cleans
> up a crashed process.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> include/sysemu/char.h | 1 +
> qapi-schema.json | 23 ++++++++++++++++-------
> qemu-char.c | 33 +++++++++++++++++++++++++++------
> qemu-options.hx | 19 +++++++++++++------
> 4 files changed, 57 insertions(+), 19 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-07-28 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 13:16 [Qemu-devel] [PATCH v2 0/4] libqtest: solve QEMU process cleanup problem Stefan Hajnoczi
2014-07-25 13:16 ` [Qemu-devel] [PATCH v2 1/4] vl: add qemu_system_shutdown_force() Stefan Hajnoczi
2014-07-25 13:16 ` [Qemu-devel] [PATCH v2 2/4] libqemustub: " Stefan Hajnoczi
2014-07-25 13:16 ` [Qemu-devel] [PATCH v2 3/4] qemu-char: add -chardev exit-on-eof option Stefan Hajnoczi
2014-07-28 21:21 ` Eric Blake [this message]
2014-07-25 13:16 ` [Qemu-devel] [PATCH v2 4/4] libqtest: use -chardev exit-on-eof to clean up QEMU Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D6BED6.6070709@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.