From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Antony Pavlov <antonynpavlov@gmail.com>, barebox@lists.infradead.org
Subject: Re: [PATCH v2] led: try to get LED's label from the 'label' property
Date: Mon, 28 Jul 2014 23:33:47 +0200 [thread overview]
Message-ID: <53D6C1BB.8040408@gmail.com> (raw)
In-Reply-To: <1406582555-10222-1-git-send-email-antonynpavlov@gmail.com>
On 07/28/2014 11:22 PM, Antony Pavlov wrote:
I personally _always_ prefer a commit message...
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> drivers/led/led-gpio.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/led/led-gpio.c b/drivers/led/led-gpio.c
> index 7bb3b49..b36f629 100644
> --- a/drivers/led/led-gpio.c
> +++ b/drivers/led/led-gpio.c
> @@ -206,13 +206,18 @@ static int led_gpio_of_probe(struct device_d *dev)
> struct gpio_led *gled;
> enum of_gpio_flags flags;
> int gpio;
> + const char *label;
>
> gpio = of_get_named_gpio_flags(child, "gpios", 0, &flags);
> if (gpio < 0)
> continue;
>
> gled = xzalloc(sizeof(*gled));
> - gled->led.name = xstrdup(child->name);
> + label = of_get_property(child, "label", NULL);
of_property_read_string() ?
Sebastian
> + if (!label)
> + label = child->name;
> + gled->led.name = xstrdup(label);
> +
> gled->gpio = gpio;
> gled->active_low = (flags & OF_GPIO_ACTIVE_LOW) ? 1 : 0;
>
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-07-28 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 21:22 [PATCH v2] led: try to get LED's label from the 'label' property Antony Pavlov
2014-07-28 21:33 ` Sebastian Hesselbarth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D6C1BB.8040408@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.