From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc Date: Mon, 28 Jul 2014 17:42:31 -0600 Message-ID: <53D6DFE7.3040901@wwwdotorg.org> References: <1404399697-26484-1-git-send-email-nick.dyer@itdev.co.uk> <53CECAEC.8080905@wwwdotorg.org> <53CFD50C.4040509@itdev.co.uk> <53CFEF6E.2060905@wwwdotorg.org> <53D10E78.4010908@itdev.co.uk> <53D17845.4020507@wwwdotorg.org> <53D26572.3030404@itdev.co.uk> <53D2B8D0.5090000@wwwdotorg.org> <53D6BF50.3070306@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:33272 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbaG1Xmd (ORCPT ); Mon, 28 Jul 2014 19:42:33 -0400 In-Reply-To: <53D6BF50.3070306@wwwdotorg.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Yufeng Shen , Nick Dyer Cc: Dmitry Torokhov , benson Leung , Daniel Kurtz , Henrik Rydberg , Joonyoung Shim , Alan Bowens , linux-input , "linux-kernel@vger.kernel.org" , Peter Meerwald , Olof Johansson , Sekhar Nori On 07/28/2014 03:23 PM, Stephen Warren wrote: > On 07/28/2014 02:20 PM, Yufeng Shen wrote: ... >> Where did you get the configuration file ? It is possible that we rely >> too much on mxt_start to turn on the T9.CTRL bit and have neglected >> its setting in the config file. >> If you can tell me where you get the config file I can do a check. > > It was already flashed into the touchpad when I received the board. I > did try to track down the firmware/config files a few months ago, but > didn't manage to; I was told since they were already flashed so I didn't > need them. The board is Venice2. OK, I received the configuration and firmware file that's supposed to be in the touchpad. I can see that the config file I was given has the "83" byte in the T9 configuration, and in fact /almost/ exactly matches the configuration I have. I don't know why my T9 configuration was wrong before, but I suspect it's not worth trying to track that down. Anyway, here's the diff between the two config files: > # diff -u mxt-save-after-t9-83-write.xml 224sl.raw > --- mxt-save-after-t9-83-write.xml 2014-07-25 19:41:45.000000000 +0000 > +++ 224sl.raw 2014-07-28 23:25:49.000000000 +0000 > @@ -1,8 +1,7 @@ > OBP_RAW V1 > 82 01 10 AA 12 0C 16 > F5AF33 > -000000 > -0025 0000 0082 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > +E21E65 > 0026 0000 0008 00 00 00 00 00 00 00 00 > 0007 0000 0004 20 10 32 00 > 0008 0000 000A 1E 00 28 28 00 00 00 00 00 00 It seems that the T25(?) entry is missing in the new/expected configuration file. I figured I'd try out the new/expected configuration file, so did: # ./obp-utils/mxt-app -d i2c-dev:1-004b --load 224sl.raw # ./obp-utils/mxt-app -d i2c-dev:1-004b --save mxt-save-after-loading-224sl.raw.xml At this point, mxt-save-after-loading-224sl.raw.xml contains identical content to mxt-save-after-t9-83-write.xml (my previous backup). It looks like the new configuration isn't being loaded correctly, or perhaps configuration loading doesn't delete entries that are simply not in the new configuration file? I subsequently did the following in case --save is reading from the NVRAM rather than RAM: # ./obp-utils/mxt-app -d i2c-dev:1-004b --backup # ./obp-utils/mxt-app -d i2c-dev:1-004b --save mxt-save-after-loading-224sl.raw.xml ... but that made no difference. I haven't yet tried upgrading or otherwise using the new firmware image. I'd like to make sure config load/save is fully working first, in case there's any common problem between the two.