From: Matthias Schwarzott <zzam@gentoo.org>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH] si2135: Declare the structs even if frontend is not enabled
Date: Tue, 29 Jul 2014 07:38:38 +0200 [thread overview]
Message-ID: <53D7335E.2010806@gentoo.org> (raw)
In-Reply-To: <1406554705-10296-1-git-send-email-m.chehab@samsung.com>
On 28.07.2014 15:38, Mauro Carvalho Chehab wrote:
> As reported by Kbuildtest:
>
> In file included from drivers/media/usb/cx231xx/cx231xx-dvb.c:35:0:
> drivers/media/dvb-frontends/si2165.h:57:9: warning: 'struct si2165_config' declared inside parameter list [enabled by default]
> struct i2c_adapter *i2c)
> ^
> drivers/media/dvb-frontends/si2165.h:57:9: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> drivers/media/usb/cx231xx/cx231xx-dvb.c:157:21: error: variable 'hauppauge_930C_HD_1113xx_si2165_config' has initializer but incomplete type
> static const struct si2165_config hauppauge_930C_HD_1113xx_si2165_config = {
> ^
> drivers/media/usb/cx231xx/cx231xx-dvb.c:158:2: error: unknown field 'i2c_addr' specified in initializer
> .i2c_addr = 0x64,
> ^
Good catch.
Matthias
prev parent reply other threads:[~2014-07-29 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 13:38 [PATCH] si2135: Declare the structs even if frontend is not enabled Mauro Carvalho Chehab
2014-07-29 5:38 ` Matthias Schwarzott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D7335E.2010806@gentoo.org \
--to=zzam@gentoo.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.