Re: [Xen-devel] [PATCH V2 1/4] Add XEN pvSCSI protocol description

[Juergen Gross <jgross@suse.com>]

On 07/28/2014 04:28 PM, David Vrabel wrote:
> On 25/07/14 12:37, jgross@suse.com wrote:
>> From: Juergen Gross <jgross@suse.com>
>>
>> Add the definition of pvSCSI protocol used between the pvSCSI frontend in a
>> XEN domU and the pvSCSI backend in a XEN driver domain (usually Dom0).
>>
>> This header was originally provided by Fujitsu for XEN based on Linux 2.6.18.
>> Changes are:
>> - added comment
>> - adapt to Linux style guide
>> - add support for larger SG-lists by putting them in an own granted page
>> - remove stale definitions
>
> This is a protocol extension and needs to be reviewed separately, and
> the Xen header needs updating as well.

Sure. The review can start right now. Updating the Xen header will be
done as soon as the drivers are accepted in Linux.

> The documentation for this protocol is rather lacking.  In particular it
> is missing the connection states.

Regarding documentation: I'll add some.

Regarding the connection states: I'd rather move the description in
blkif.h to xenbus.h than duplicating it in vscsiif.h. What do you think?


Juergen