All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: "Michel Dänzer" <michel@daenzer.net>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/radeon: Use write-combined CPU mappings of ring buffers with PCIe
Date: Tue, 29 Jul 2014 11:54:38 +0200	[thread overview]
Message-ID: <53D76F5E.4040908@vodafone.de> (raw)
In-Reply-To: <1406627242-14901-1-git-send-email-michel@daenzer.net>

Am 29.07.2014 um 11:47 schrieb Michel Dänzer:
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> PCI GART doesn't support unsnooped access. AGP GART already uses
> write-combined CPU mappings.
>
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>

For this series Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/radeon/radeon_ring.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ring.c b/drivers/gpu/drm/radeon/radeon_ring.c
> index 71439f0..7cfea7e 100644
> --- a/drivers/gpu/drm/radeon/radeon_ring.c
> +++ b/drivers/gpu/drm/radeon/radeon_ring.c
> @@ -640,7 +640,9 @@ int radeon_ring_init(struct radeon_device *rdev, struct radeon_ring *ring, unsig
>   	/* Allocate ring buffer */
>   	if (ring->ring_obj == NULL) {
>   		r = radeon_bo_create(rdev, ring->ring_size, PAGE_SIZE, true,
> -				     RADEON_GEM_DOMAIN_GTT, 0,
> +				     RADEON_GEM_DOMAIN_GTT,
> +				     (rdev->flags & RADEON_IS_PCIE) ?
> +				     RADEON_GEM_GTT_WC : 0,
>   				     NULL, &ring->ring_obj);
>   		if (r) {
>   			dev_err(rdev->dev, "(%d) ring create failed\n", r);

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2014-07-29  9:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29  9:47 [PATCH 1/3] drm/radeon: Use write-combined CPU mappings of ring buffers with PCIe Michel Dänzer
2014-07-29  9:47 ` [PATCH 2/3] drm/radeon: Use write-combined CPU mappings of IBs on >= CIK Michel Dänzer
2014-07-29  9:47 ` [PATCH 3/3] drm/radeon/cik: Read back SDMA WPTR register after writing it Michel Dänzer
2014-07-29  9:54 ` Christian König [this message]
2014-07-29 13:14   ` [PATCH 1/3] drm/radeon: Use write-combined CPU mappings of ring buffers with PCIe Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D76F5E.4040908@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=michel@daenzer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.