Re: [PATCH v2] MIPS: BCM47XX: fixup broken MAC addresses in nvram

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 07/29/2014 02:08 AM, Hauke Mehrtens wrote:

> The address prefix 00:90:4C is used by Broadcom in their initial
> configuration. When a mac address with the prefix 00:90:4C is used all
> devices from the same series are sharing the same mac address. To
> prevent mac address collisions we replace them with a mac address based
> on the base address. To generate such addresses we take the main mac
> address from et0macaddr and increase it by two for the first wifi
> device and by 3 for the second one. This matches the printed mac
> address on the device. The main mac address increased by one is used as
> wan address by the vendor code.

> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---

> v1: fix checkpatch warnings

>   arch/mips/bcm47xx/sprom.c | 48 +++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 48 insertions(+)

> diff --git a/arch/mips/bcm47xx/sprom.c b/arch/mips/bcm47xx/sprom.c
> index da4cdb1..41226b6 100644
> --- a/arch/mips/bcm47xx/sprom.c
> +++ b/arch/mips/bcm47xx/sprom.c
[...]
> @@ -648,6 +677,25 @@ static void bcm47xx_fill_sprom_ethernet(struct ssb_sprom *sprom,
>
>   	nvram_read_macaddr(prefix, "macaddr", sprom->il0mac, fallback);
>   	nvram_read_macaddr(prefix, "il0macaddr", sprom->il0mac, fallback);
> +
> +	/* The address prefix 00:90:4C is used by Broadcom in their initial
> +	   configuration. When a mac address with the prefix 00:90:4C is used
> +	   all devices from the same series are sharing the same mac address.
> +	   To prevent mac address collisions we replace them with a mac address
> +	   based on the base address. */

    The preferred multi-line comment style in the kernel is this:

/*
  * bla
  * bla
  */

WBR, Sergei